138: Properly scope all internal functions in S2Connection. #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion-private-by-prefixing-an-underscore
wcoenraads
approved these changes
Oct 27, 2025
Collaborator
wcoenraads
left a comment
wcoenraads
left a comment
There was a problem hiding this comment.
Looks good, thanks Sebastiaan!
jorritn
reviewed
Oct 27, 2025
| ).result() | ||
|
|
||
| async def send_msg_and_await_reception_status_async( | ||
| async def _send_msg_and_await_reception_status_async( |
Contributor
There was a problem hiding this comment.
Only the sync functions are supposed to be used in the ControlType implementations, right?
Member
Author
There was a problem hiding this comment.
Currently yes. I am going to work on adding an async interface.
jorritn
approved these changes
Oct 27, 2025
lfse-slafleur
deleted the
138-make-all-internal-functions-of-s2connection-private-by-prefixing-an-underscore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.