Move AssetDetails and MessageHandlers into separate files to reduce dependency on websockets #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipptrenz
force-pushed
the
reduce-websockets-dependency
branch
from
f22f43d to
34a3948
Compare
lfse-slafleur
approved these changes
Nov 26, 2025
Member
|
@philipptrenz Changes look good, but some linting issues remain. Once fixed, lets get your changes in! |
philipptrenz
force-pushed
the
reduce-websockets-dependency
branch
from
a597687 to
1659da2
Compare
philipptrenz
commented
Nov 26, 2025
Contributor
Author
|
@lfse-slafleur I left you a comment. If you're fine with that, then we should be done. |
philipptrenz
force-pushed
the
reduce-websockets-dependency
branch
from
1659da2 to
6c08f17
Compare
lfse-slafleur
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.