86 fix typing so also pyright can reason that s2 python is correct #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lasses is the actual class instead of S2MessageComponent.
…eritance structure significantly by using Self.
…t-s2-python-is-correct
lfse-slafleur
requested review from
Flix6x,
VladIftime,
victorgarcia98 and
wcoenraads
lfse-slafleur
commented
Mar 24, 2025
VladIftime
reviewed
Mar 24, 2025
VladIftime
reviewed
Mar 24, 2025
VladIftime
approved these changes
Mar 24, 2025
Collaborator
VladIftime
left a comment
VladIftime
left a comment
There was a problem hiding this comment.
Looks good. An extensive PR, but a lot of improvements were added.
…t-s2-python-is-correct
lfse-slafleur
deleted the
86-fix-typing-so-also-pyright-can-reason-that-s2-python-is-correct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.