Align Runway generators with skeleton App\ layout - #714
Merged
Conversation
make:controller now generates App\Controller under app/Controller/, and ai:generate-instructions writes only AGENTS.md with Twig/SimplePdo conventions. Clear a stale PHPStan baseline entry and resolve PHPCS issues so multi-PHP tests/phpstan/phpcs pass cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make:controller: generatesApp\Controller\…underapp/Controller/(matches flightphp/skeleton layout) instead ofapp\controllers.ai:generate-instructions: writes only rootAGENTS.md(no Copilot/Cursor/Gemini/Windsurf dumps); prefers existing AGENTS.md for context (falls back to legacy copilot file); defaults templating to Twig; LLM prompt encodesApp\…, Engine injection, SimplePdo, and AGENTS.md-only conventions.composer.jsonsuggest: recommend Twig (keep Latte as optional).parseStringClassAndMethod; fix PHPCS issues (string concat, Loader@templateorder, SimplePdo cast spacing, test heredocs) sotests/run_all_tests.shis green on PHP 7.4 / 8.2 / 8.3.Test plan
bash tests/run_all_tests.sh(PHPUnit + PHPStan + PHPCS on available PHP versions)ControllerCommandandAiGenerateInstructionsCommandphp runway make:controller Fooin a skeleton-style app → file atapp/Controller/FooController.phpwithnamespace App\Controllerphp runway ai:generate-instructions→ only updatesAGENTS.md