Skip to content

chore(deps): update dependency eslint-plugin-react-hooks to v7#45

Merged
dargmuesli merged 2 commits intomainfrom
renovate/major-react-monorepo
Nov 14, 2025
Merged

chore(deps): update dependency eslint-plugin-react-hooks to v7#45
dargmuesli merged 2 commits intomainfrom
renovate/major-react-monorepo

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate Bot commented Oct 9, 2025

This PR contains the following updates:

Package Change Age Confidence
eslint-plugin-react-hooks (source) 6.1.1 -> 7.0.1 age confidence

Release Notes

facebook/react (eslint-plugin-react-hooks)

v7.0.1

Compare Source

v7.0.0

Compare Source

This release slims down presets to just 2 configurations (recommended and recommended-latest), and all compiler rules are enabled by default.

  • Breaking: Removed recommended-latest-legacy and flat/recommended configs. The plugin now provides recommended (legacy and flat configs with all recommended rules), and recommended-latest (legacy and flat configs with all recommended rules plus new bleeding edge experimental compiler rules). (@​poteto in #​34757)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot force-pushed the renovate/major-react-monorepo branch 3 times, most recently from 75c2638 to 025a212 Compare October 18, 2025 04:56
@renovate renovate Bot force-pushed the renovate/major-react-monorepo branch 2 times, most recently from 055cd99 to 5014ccc Compare October 24, 2025 22:00
@renovate renovate Bot force-pushed the renovate/major-react-monorepo branch 2 times, most recently from 4be4c9b to e96219d Compare November 4, 2025 05:33
@renovate renovate Bot force-pushed the renovate/major-react-monorepo branch from e96219d to 9ebabc6 Compare November 11, 2025 00:30
Copy link
Copy Markdown
Member

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapted the code a bit, @soerface pls verify

@dargmuesli dargmuesli requested a review from soerface November 12, 2025 21:57
@dargmuesli
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

@soerface soerface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapted the code a bit, @soerface pls verify

Thanks! Read briefly the linked article https://react.dev/learn/you-might-not-need-an-effect. I'm really not familiar with that stuff, just wondering how you came to the conclusion that useRef is the proper solution, as it doesn't seem to be mentioned in the article.

I'm currently without a laptop and therefore unable to test the change myself. It will take a couple weeks until I can have a closer look. If you feel confident that this is the right solution you can go ahead, but since you already opened PR upstream I would recommend waiting for feedback from the devs there. I've also subscribed to your upstream issue & PR.

Thank you so much for maintaining this!

@dargmuesli
Copy link
Copy Markdown
Member

useEffect should be used for changes triggering rerenders and hasTriedSignin appears to be just a flag that prevents starting the signin process more than once. hasTriedSignin does not influence the JSX rendering as far as I see, so useRef can be used instead I think.

@renovate
Copy link
Copy Markdown
Contributor Author

renovate Bot commented Nov 13, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@dargmuesli
Copy link
Copy Markdown
Member

Merging this as the linked upstream PR was merged by the maintainers :)

@dargmuesli dargmuesli merged commit 7ae8ab9 into main Nov 14, 2025
4 checks passed
@dargmuesli dargmuesli deleted the renovate/major-react-monorepo branch November 14, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants