chore(deps): update dependency eslint-plugin-react-hooks to v7#45
chore(deps): update dependency eslint-plugin-react-hooks to v7#45dargmuesli merged 2 commits intomainfrom
Conversation
75c2638 to
025a212
Compare
055cd99 to
5014ccc
Compare
4be4c9b to
e96219d
Compare
e96219d to
9ebabc6
Compare
dargmuesli
left a comment
There was a problem hiding this comment.
Adapted the code a bit, @soerface pls verify
|
Also submitted this change upstream: |
soerface
left a comment
There was a problem hiding this comment.
Adapted the code a bit, @soerface pls verify
Thanks! Read briefly the linked article https://react.dev/learn/you-might-not-need-an-effect. I'm really not familiar with that stuff, just wondering how you came to the conclusion that useRef is the proper solution, as it doesn't seem to be mentioned in the article.
I'm currently without a laptop and therefore unable to test the change myself. It will take a couple weeks until I can have a closer look. If you feel confident that this is the right solution you can go ahead, but since you already opened PR upstream I would recommend waiting for feedback from the devs there. I've also subscribed to your upstream issue & PR.
Thank you so much for maintaining this!
|
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
Merging this as the linked upstream PR was merged by the maintainers :) |
This PR contains the following updates:
6.1.1->7.0.1Release Notes
facebook/react (eslint-plugin-react-hooks)
v7.0.1Compare Source
useEffectEventvalues as JSX props to guard against accidental propagation. (#34820 by @jf-eirinha)export =so eslint-plugin-react-hooks emits correct types for consumers in Node16 ESM projects. (#34949 by @karlhorky)configs.flatso theconfigsexport is always defined. (#34950 by @poteto)v7.0.0Compare Source
This release slims down presets to just 2 configurations (
recommendedandrecommended-latest), and all compiler rules are enabled by default.recommended-latest-legacyandflat/recommendedconfigs. The plugin now providesrecommended(legacy and flat configs with all recommended rules), andrecommended-latest(legacy and flat configs with all recommended rules plus new bleeding edge experimental compiler rules). (@poteto in #34757)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.