Support table prefixes in ActiveRecord adapter - #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActiveRecord users can namespace Flipper tables with
table_prefix:without defining custom feature and gate model classes. The adapter creates internal subclasses that target the prefixed tables while preserving explicitfeature_classandgate_classoverrides.Both
flipper:active_recordandflipper:updateaccept--table-prefix, so initial migrations and future schema updates generate matching table names, migration filenames, and migration classes without manual edits.Validation
git diff --checkThe broader Redis-backed Minitest suite was not run because it requires
FLUSHDBagainst a local Redis instance.