feat: add devcontainer setup for Flipt v2 development#5542
Merged
markphelps merged 5 commits intov2from Mar 12, 2026
Merged
Conversation
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5542 +/- ##
=======================================
Coverage 60.40% 60.40%
=======================================
Files 141 141
Lines 13995 13995
=======================================
Hits 8453 8453
Misses 4821 4821
Partials 721 721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Pre-create volume mount points in Dockerfile with correct ownership - Disable Node.js GPG verification (gpg/keyboxd unavailable in containers) - Fix chown on volume mounts in postCreateCommand for pre-existing volumes - Remove node_modules volume mount (causes permission issues, minimal benefit) - Fix npx --no to --yes for non-interactive package-changed installs - Add CI workflow to build and validate devcontainer on changes Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Contributor
|
I maybe wrong here but we probably don't need "features": {
"ghcr.io/devcontainers-extra/features/mise:1": {},
"ghcr.io/devcontainers/features/git:1.3.5": {}
}, |
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a complete devcontainer configuration for Flipt v2 development, enabling one-click setup in VS Code, GitHub Codespaces, or any devcontainer-compatible environment.
postCreateCommand.devcontainer/changes to prevent regressionsNotable fixes
vscodeuser so Docker initializes named volumes with correct ownershipchownsafety net inpostCreateCommandfor pre-existing volumesnode_modulesvolume mount (root ownership causes permission errors, minimal caching benefit sincenpm cidoes clean installs)npx --no→npx --yesfor non-interactivepackage-changedinstalls