chore: simplify devcontainer setup by removing Dockerfile#5558
Merged
markphelps merged 4 commits intov2from Mar 13, 2026
Merged
chore: simplify devcontainer setup by removing Dockerfile#5558markphelps merged 4 commits intov2from
markphelps merged 4 commits intov2from
Conversation
Replace custom Dockerfile with base devcontainer image and mise feature. Move build-essential/pkg-config install to postCreateCommand. Also update .gitignore to ignore docs/ instead of just docs/plans. Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5558 +/- ##
=======================================
Coverage 60.40% 60.40%
=======================================
Files 141 141
Lines 13995 13995
=======================================
Hits 8453 8453
Misses 4821 4821
Partials 721 721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dosubot
Bot
added
the
size:M
The mise trust command needs ~/.local/state/mise/trusted-configs which doesn't exist by default. Create and chown it alongside the other mise directories to fix the permission denied error in CI. Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Move the long one-liner into .devcontainer/setup.sh for readability and easier maintenance. Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
erka
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-essential/pkg-configinstall topostCreateCommand.gitignoreto ignoredocs/instead of justdocs/plansBased on feedback from @erka in #5542.
cc @erka