Skip to content

chore: modernize CI and add astro check - #174

Merged
magnus-madsen merged 1 commit into
masterfrom
chore/ci-modernization
Aug 3, 2026
Merged

chore: modernize CI and add astro check#174
magnus-madsen merged 1 commit into
masterfrom
chore/ci-modernization

Conversation

@magnus-madsen

Copy link
Copy Markdown
Member

Summary

Modernizes the CI workflow and tightens up the build setup:

CI workflow

  • Update actions/checkout v4 → v5 and actions/setup-node v4 → v6
  • Test on Node 22.x and 24.x (current maintenance and active LTS lines)
  • Add permissions: contents: read (least-privilege token)
  • Add concurrency group that cancels superseded PR runs (master pushes always run to completion)
  • Add a 5-minute job timeout and a workflow_dispatch trigger for manual runs
  • Drop --if-present from the build step and fix the stale header comment

Type checking

  • Add astro check as a CI step with @astrojs/check + typescript devDependencies and a minimal tsconfig.json extending astro/tsconfigs/base — currently passes with 0 errors/warnings across all 18 files

Reproducible builds

  • Pin the flix.tmLanguage.json fetch to a specific commit of flix/textmate instead of tracking master HEAD; bump the SHA in build-scripts/fetchGrammar.mjs to pick up grammar changes

Housekeeping

  • Declare engines: { node: ">=22" } and add .nvmrc so contributors get warned/switched to a compatible Node
  • Remove stale /src/data entry from .gitignore

Test plan

  • npm run check passes locally (0 errors, 0 warnings, 0 hints)
  • npm run build builds all 9 pages cleanly with the pinned grammar URL
  • CI green on this PR across the Node 22/24 matrix

🤖 Generated with Claude Code

- Update actions/checkout to v5 and actions/setup-node to v6
- Test on Node 22.x and 24.x (current maintenance and active LTS)
- Add least-privilege permissions, concurrency cancellation for PRs,
  5-minute job timeout, and workflow_dispatch trigger
- Add astro check (with @astrojs/check + typescript and tsconfig.json)
- Pin flix.tmLanguage.json fetch to a specific commit for reproducible builds
- Declare Node >=22 via engines field and .nvmrc
- Remove stale /src/data entry from .gitignore

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@magnus-madsen
magnus-madsen force-pushed the chore/ci-modernization branch from c90045d to 72c012c Compare August 3, 2026 05:02
@magnus-madsen
magnus-madsen merged commit 0aa3b92 into master Aug 3, 2026
2 checks passed
@magnus-madsen
magnus-madsen deleted the chore/ci-modernization branch August 3, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant