Skip to content

fix: add header and main landmarks for accessibility #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magnus-madsen merged 1 commit into from
Aug 3, 2026
Merged

fix: add header and main landmarks for accessibility #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 35 additions & 29 deletions src/layouts/Layout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,38 +65,44 @@ import '../styles/global.css';
<link href="/favicon.png" rel="icon">
</head>
<body>
<a href="https://github.com/flix/flix">
<img style="position: absolute; top: 0; right: 0; border: 0; z-index: 9999;"
src="/forkme_right_green_007200.png"
alt="Fork me on GitHub">
</a>
<div class="container page">
<nav class="navbar navbar-dark bg-info navbar-expand-md menu shadow-sm mb-4">
<div class="container-fluid">
<button
class="navbar-toggler"
type="button"
aria-controls="main-nav"
aria-expanded="false"
aria-label="Toggle navigation"
>
<span class="navbar-toggler-icon"></span>
</button>
<div class="collapse navbar-collapse" id="main-nav">
<ul class="navbar-nav mr-lg-auto">
{navLinks.map(({ href, label }) => (
<li class="nav-item pl-1 pr-1">
<a class={`nav-link${currentPath === href ? " active font-weight-bold" : ""}`} href={href}>
{label}
</a>
</li>
))}
</ul>
<header>
{/* The ribbon is absolutely positioned against the viewport, so its
place in the DOM only affects the reading order, not the layout. */}
<a href="https://github.com/flix/flix">
<img style="position: absolute; top: 0; right: 0; border: 0; z-index: 9999;"
src="/forkme_right_green_007200.png"
alt="Fork me on GitHub">
</a>
<nav class="navbar navbar-dark bg-info navbar-expand-md menu shadow-sm mb-4" aria-label="Main">
<div class="container-fluid">
<button
class="navbar-toggler"
type="button"
aria-controls="main-nav"
aria-expanded="false"
aria-label="Toggle navigation"
>
<span class="navbar-toggler-icon"></span>
</button>
<div class="collapse navbar-collapse" id="main-nav">
<ul class="navbar-nav mr-lg-auto">
{navLinks.map(({ href, label }) => (
<li class="nav-item pl-1 pr-1">
<a class={`nav-link${currentPath === href ? " active font-weight-bold" : ""}`} href={href}>
{label}
</a>
</li>
))}
</ul>
</div>
</div>
</div>
</nav>
</nav>
</header>

<slot />
<main>
<slot />
</main>
</div>

<script>
Expand Down