Skip to content

refactor: use ParYield in RedBlackTree#4915

Merged
magnus-madsen merged 20 commits intoflix:masterfrom
jaschdoc:rbtree_paryield
Nov 15, 2022
Merged

refactor: use ParYield in RedBlackTree#4915
magnus-madsen merged 20 commits intoflix:masterfrom
jaschdoc:rbtree_paryield

Conversation

@jaschdoc
Copy link
Copy Markdown
Member

@jaschdoc jaschdoc commented Nov 14, 2022

Should wait for #4913
Closes #4867

@jaschdoc jaschdoc marked this pull request as ready for review November 14, 2022 15:57
@magnus-madsen
Copy link
Copy Markdown
Member

@jaschdoc Can I merge this even though something is broken or?

@jaschdoc
Copy link
Copy Markdown
Member Author

Are you referring to #4917 ?

@jaschdoc
Copy link
Copy Markdown
Member Author

@jaschdoc Can I merge this even though something is broken or?

Nothing should be broken on this branch :)

@magnus-madsen
Copy link
Copy Markdown
Member

  • Conflicts (with Matt's apologies; bad timing).
  • left -> l, right -> r
  • this -> v or nv or something. Just not this or val or some Scala keyword :D

@jaschdoc
Copy link
Copy Markdown
Member Author

Any thoughts on indentation of yield?

@mlutze
Copy link
Copy Markdown
Member

mlutze commented Nov 15, 2022

Any thoughts on indentation of yield?

Here's the way I would do it:

par (
    x <- e1;
    y <- e2;
) yield (x, y)

Which matches Scala style

@magnus-madsen
Copy link
Copy Markdown
Member

Any thoughts on indentation of yield?

Here's the way I would do it:

par (
    x <- e1;
    y <- e2;
) yield (x, y)

Which matches Scala style

Yes, but if there are few elements (like two) its OK to keep it on the same line IMO

@jaschdoc
Copy link
Copy Markdown
Member Author

Alright done

@magnus-madsen
Copy link
Copy Markdown
Member

Pretty nice cleanup, right? 👍

@magnus-madsen magnus-madsen merged commit 8ceeb19 into flix:master Nov 15, 2022
@jaschdoc jaschdoc deleted the rbtree_paryield branch November 15, 2022 16:20
@jaschdoc
Copy link
Copy Markdown
Member Author

Yeah very

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use ParYield in Standard Library (e.g. RedBlackTree)

3 participants