refactor: use ParYield in RedBlackTree#4915
Merged
magnus-madsen merged 20 commits intoflix:masterfrom Nov 15, 2022
Merged
Conversation
Member
|
@jaschdoc Can I merge this even though something is broken or? |
Member
Author
|
Are you referring to #4917 ? |
Member
Author
Nothing should be broken on this branch :) |
Member
|
Member
Author
|
Any thoughts on indentation of |
Member
Here's the way I would do it: Which matches Scala style |
Member
Yes, but if there are few elements (like two) its OK to keep it on the same line IMO |
Member
Author
|
Alright done |
Member
|
Pretty nice cleanup, right? 👍 |
Member
Author
|
Yeah very |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should wait for #4913
Closes #4867