Fixed absolute symlink issue for gdb files while packing conda env - #57
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the conda-pack command to exclude GDB debugging files from the packed environment archive, potentially reducing the packed environment size.
- Added
--exclude "share/gdb/*"flag to the conda-pack command to filter out GDB debugger files
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| print(f"[environment] Packing environment into '{output_file}'...") | ||
| cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force"] | ||
| cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"] |
There was a problem hiding this comment.
There is trailing whitespace at the end of this line. Remove the trailing space after the closing bracket for consistency with code style.
| cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"] | |
| cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"] |
| @@ -157,7 +157,7 @@ def create_conda_pack_from_yml( | |||
| print(f"[environment] Post-installation script executed successfully.") | |||
|
|
|||
| print(f"[environment] Packing environment into '{output_file}'...") | |||
There was a problem hiding this comment.
Consider adding a comment explaining why GDB files are being excluded from the packed environment. This would help future maintainers understand the rationale behind this exclusion (e.g., reducing package size, removing unnecessary debug symbols).
| print(f"[environment] Packing environment into '{output_file}'...") | |
| print(f"[environment] Packing environment into '{output_file}'...") | |
| # Exclude GDB files to reduce package size and remove unnecessary debug symbols, | |
| # as they are not required for running the environment. |
There was a problem hiding this comment.
@copilot Add comment - # Exclude GDB debug files which contain absolute symlinks that break conda-pack
|
@saifulislampi I've opened a new pull request, #58, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@saifulislampi I've opened a new pull request, #59, to work on those changes. Once the pull request is ready, I'll request review from you. |
Added exclusion for GDB debug files in conda-pack command.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force"] | ||
|
|
||
| # Exclude GDB debug files which contain absolute symlinks that break conda-pack | ||
| cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"] |
There was a problem hiding this comment.
Trailing whitespace at the end of the line should be removed for consistency with the project's formatting standards.
| cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"] | |
| cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"] |
No description provided.