Skip to content

fix: resolve sent folders#1643

Merged
andrinoff merged 1 commit into
floatpane:masterfrom
andrinoff:fix/sent-folders
Jul 6, 2026
Merged

fix: resolve sent folders#1643
andrinoff merged 1 commit into
floatpane:masterfrom
andrinoff:fix/sent-folders

Conversation

@andrinoff

Copy link
Copy Markdown
Member

What?

All Sent mailbox lookups now resolve via getMailboxByAttr(c, imap.MailboxAttrSent) with fallback to the hardcoded getSentMailbox, matching the existing Trash/Archive pattern.

Why?

Fixes #1641

Signed-off-by: drew <me@andrinoff.com>
@andrinoff andrinoff requested a review from a team as a code owner July 2, 2026 20:14
@floatpanebot floatpanebot added bug Something isn't working area/fetcher IMAP fetch / IDLE / search size/M Diff: 51–200 lines backport/v1 Merge to master and backport to release/v1 labels Jul 2, 2026
@andrinoff

Copy link
Copy Markdown
Member Author

/approve

@andrinoff andrinoff enabled auto-merge July 6, 2026 09:09

@floatpanebot floatpanebot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @andrinoff via /approve command.

@andrinoff andrinoff added this pull request to the merge queue Jul 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 6, 2026
@andrinoff andrinoff added this pull request to the merge queue Jul 6, 2026
Merged via the queue into floatpane:master with commit 510a1db Jul 6, 2026
31 checks passed
@andrinoff andrinoff deleted the fix/sent-folders branch July 6, 2026 09:46
@floatpanebot

Copy link
Copy Markdown
Member

Backport to release/v1 hit a conflict — cherry-pick it manually:

git fetch origin
git checkout release/v1
git cherry-pick -x 510a1db24e2a7275a6c963f7ebcacd766788ab0f
# resolve conflicts, then:
git push origin release/v1

@floatpanebot floatpanebot added the backport-failed Cherry-pick conflict — needs manual backport label Jul 6, 2026
@floatpane floatpane deleted a comment from andrinoff Jul 6, 2026
@floatpane floatpane deleted a comment from andrinoff Jul 6, 2026
@floatpane floatpane deleted a comment from andrinoff Jul 6, 2026
andrinoff added a commit that referenced this pull request Jul 6, 2026
All Sent mailbox lookups now resolve via `getMailboxByAttr(c,
imap.MailboxAttrSent)` with fallback to the hardcoded `getSentMailbox`,
matching the existing Trash/Archive pattern.

Fixes #1641

Signed-off-by: drew <me@andrinoff.com>
(cherry picked from commit 510a1db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/fetcher IMAP fetch / IDLE / search backport/v1 Merge to master and backport to release/v1 backport-failed Cherry-pick conflict — needs manual backport bug Something isn't working size/M Diff: 51–200 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saving to Sent fails on non-English Exchange/Office 365 (APPEND uses a hardcoded folder name instead of the \Sent special-use attribute)

2 participants