fix(flow-php/symfony-telemetry-bundle): stop calling Router::getRouteCollection() on every request - #2525
Merged
Merged
Conversation
…Collection() on every request with route_naming: pat - add RouteNamePathMap: ConfigCache-backed [route name => path] map, warmed at cache:warmup (optional warmer) or lazily on first use - HttpKernelSpanSubscriber takes ?RouteNamePathMap instead of ?RouterInterface; routeValue() is an O(1) lookup - degrade to route-name naming (never touch the router at runtime) when the map cannot be built
norberttech
added
the
hackaton-07-2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2525 +/- ##
============================================
- Coverage 86.27% 86.27% -0.01%
- Complexity 22924 22939 +15
============================================
Files 1739 1740 +1
Lines 70415 70460 +45
============================================
+ Hits 60753 60789 +36
- Misses 9662 9671 +9 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/symfony-telemetry-bundle-RouteNamePathMapoptional cache warmer building a[route name => path]map atcache:warmup, rebuilt lazily when missingFixed
flow-php/symfony-telemetry-bundle-route_naming: pathno longer callsRouter::getRouteCollection()(full route collection rebuild) on every traced requestChanged
flow-php/symfony-telemetry-bundle-HttpKernelSpanSubscriberconstructor takes?RouteNamePathMapinstead of?RouterInterfaceRemoved
Deprecated
Security
@bendavies I think this should work. Basically during cache:warmup it generates a flat map of
route_name => route_pathso the Telemetry Subscriber doesn't even need to touch router.If the map wasn't generated it will fallback to route_name only.