add REST API interceptors for handling more diverse permissions (identity links, variables, conditional events) by tiffmaelite · Pull Request #3141 · flowable/flowable-engine

tiffmaelite · 2021-12-10T15:55:24Z

I extended the CMMN REST API interceptor and the BPMN REST API interceptor such that it becomes possible to react on a request to access, create, edit or delete identity links for cases, processes and tasks.
In the first draft, I also made the new method generic enough to be able to use it in the future for other kinds of action intercepting, if it were to become a use case (e.g. need to intercept requests to alter entity links, comments or attachments)

Check List:

Unit tests: NO
Documentation: NA

tiffmaelite · 2021-12-13T08:08:21Z

I now applied the style settings files of the project, which I had forgotten to use.

filiphr · 2021-12-13T14:59:23Z

Thanks for the PR @tiffmaelite.

I also made the new method generic enough to be able to use it in the future for other kinds of action intercepting, if it were to become a use case (e.g. need to intercept requests to alter entity links, comments or attachments)

I understand where you are coming from. However, we are not using that pattern in the interceptors anywhere else. Therefore, can we please use dedicated methods for each action. e.g.

accessTaskIdentityLinks
updateTaskIdentityLinks
deleteTaskIdentityLinks
createTaskIdentityLinks

In addition to that some of the endpoints are invoking the access instance info by id interceptor, e.g. when getting the case instance identity links. Perhaps here we should not invoke that interceptor and only invoke the access identity links one.

tiffmaelite · 2021-12-13T16:28:02Z

@filiphr : API was changed as requested
I am not sure whether any additional permission check on the task/process/case is actually necessary (they still can be done in the new methods if needed), so I removed all of them, but let me know if you disagree

tiffmaelite · 2021-12-14T08:21:38Z

Thanks for the PR @tiffmaelite.

I also made the new method generic enough to be able to use it in the future for other kinds of action intercepting, if it were to become a use case (e.g. need to intercept requests to alter entity links, comments or attachments)

I understand where you are coming from. However, we are not using that pattern in the interceptors anywhere else. Therefore, can we please use dedicated methods for each action. e.g.

accessTaskIdentityLinks

updateTaskIdentityLinks

deleteTaskIdentityLinks

createTaskIdentityLinks

In addition to that some of the endpoints are invoking the access instance info by id interceptor, e.g. when getting the case instance identity links. Perhaps here we should not invoke that interceptor and only invoke the access identity links one.

fixed

add license headers to new files fix code style

keep feature of ensuring existence of entity for which identity links are accessed or modified apply review comments to ensure the existence check is done before calling the interceptors and to pass all relevant parameters to the interceptors

filiphr

Thanks for the changes @tiffmaelite. I've added some more comments where we can make some things more granular. Can you please have a look at my last comments and let me know what you think

…r and add interceptor of identity links for definitions

…hecks + add specific interception points for creating / updating / deleting variables

tiffmaelite · 2022-04-19T08:14:28Z

Thanks for the changes @tiffmaelite. I've added some more comments where we can make some things more granular. Can you please have a look at my last comments and let me know what you think

done

…terceptors-for-identitylinks # Conflicts: # modules/flowable-cmmn-rest/src/main/java/org/flowable/cmmn/rest/service/api/CmmnRestApiInterceptor.java # modules/flowable-cmmn-rest/src/main/java/org/flowable/cmmn/rest/service/api/repository/CaseDefinitionResource.java # modules/flowable-cmmn-rest/src/main/java/org/flowable/cmmn/rest/service/api/runtime/caze/BaseVariableResource.java # modules/flowable-cmmn-rest/src/main/java/org/flowable/cmmn/rest/service/api/runtime/caze/CaseInstanceVariableDataResource.java # modules/flowable-cmmn-rest/src/main/java/org/flowable/cmmn/rest/service/api/runtime/caze/CaseInstanceVariableResource.java # modules/flowable-cmmn-rest/src/main/java/org/flowable/cmmn/rest/service/api/runtime/task/TaskBaseResource.java # modules/flowable-cmmn-rest/src/main/java/org/flowable/cmmn/rest/service/api/runtime/task/TaskVariableResource.java # modules/flowable-rest/src/main/java/org/flowable/rest/service/api/BpmnRestApiInterceptor.java # modules/flowable-rest/src/main/java/org/flowable/rest/service/api/repository/ProcessDefinitionResource.java # modules/flowable-rest/src/main/java/org/flowable/rest/service/api/runtime/process/BaseExecutionVariableResource.java # modules/flowable-rest/src/main/java/org/flowable/rest/service/api/runtime/process/BaseProcessInstanceResource.java # modules/flowable-rest/src/main/java/org/flowable/rest/service/api/runtime/process/ExecutionVariableResource.java # modules/flowable-rest/src/main/java/org/flowable/rest/service/api/runtime/process/ProcessInstanceResource.java # modules/flowable-rest/src/main/java/org/flowable/rest/service/api/runtime/process/ProcessInstanceVariableResource.java # modules/flowable-rest/src/main/java/org/flowable/rest/service/api/runtime/task/TaskVariableResource.java

tiffmaelite · 2023-05-04T18:14:24Z

replaced by 022b6ac

dbmalkovsky reviewed Dec 10, 2021

View reviewed changes

Comment thread ...e-cmmn-rest/src/main/java/org/flowable/cmmn/rest/service/api/IdentityLinksActionRequest.java Outdated

dbmalkovsky reviewed Dec 10, 2021

View reviewed changes

Comment thread ...main/java/org/flowable/rest/service/api/runtime/task/TaskIdentityLinkCollectionResource.java Outdated

dbmalkovsky reviewed Dec 10, 2021

View reviewed changes

Comment thread ...src/main/java/org/flowable/rest/service/api/runtime/task/TaskIdentityLinkFamilyResource.java Outdated

tiffmaelite force-pushed the feature/rest-api-interceptors-for-identitylinks branch 2 times, most recently from b89cd9a to 0fc2b64 Compare December 10, 2021 16:40

tiffmaelite requested a review from dbmalkovsky December 10, 2021 16:41

tiffmaelite marked this pull request as draft December 13, 2021 15:37

tiffmaelite commented Dec 14, 2021

View reviewed changes

Comment thread ...flowable/rest/service/api/history/HistoricProcessInstanceIdentityLinkCollectionResource.java Outdated

tiffmaelite commented Dec 14, 2021

View reviewed changes

Comment thread .../main/java/org/flowable/cmmn/engine/impl/cmd/GetHistoricIdentityLinksForCaseInstanceCmd.java Outdated

tiffmaelite commented Dec 14, 2021

View reviewed changes

Comment thread ...-cmmn-engine/src/main/java/org/flowable/cmmn/engine/impl/cmd/GetIdentityLinksForTaskCmd.java Outdated

tiffmaelite marked this pull request as ready for review December 14, 2021 08:21

tiffmaelite marked this pull request as draft December 14, 2021 08:35

tiffmaelite force-pushed the feature/rest-api-interceptors-for-identitylinks branch 6 times, most recently from 3925e8d to e3040d4 Compare December 14, 2021 11:22

add REST API interceptors for handling permissions on identity links

5bd8213

add license headers to new files fix code style

tiffmaelite force-pushed the feature/rest-api-interceptors-for-identitylinks branch 2 times, most recently from 4ba8f16 to 1c74615 Compare December 14, 2021 14:07

tiffmaelite force-pushed the feature/rest-api-interceptors-for-identitylinks branch from 1c74615 to 4f67263 Compare December 14, 2021 14:11

tiffmaelite commented Dec 14, 2021

View reviewed changes

Comment thread ...wable-cmmn-rest/src/main/java/org/flowable/cmmn/rest/service/api/CmmnRestApiInterceptor.java Outdated

tiffmaelite commented Dec 14, 2021

View reviewed changes

Comment thread ...wable-cmmn-rest/src/main/java/org/flowable/cmmn/rest/service/api/CmmnRestApiInterceptor.java Outdated

tiffmaelite commented Dec 14, 2021

View reviewed changes

Comment thread modules/flowable-rest/src/main/java/org/flowable/rest/service/api/BpmnRestApiInterceptor.java Outdated

tiffmaelite commented Dec 14, 2021

View reviewed changes

Comment thread modules/flowable-rest/src/main/java/org/flowable/rest/service/api/BpmnRestApiInterceptor.java Outdated

tiffmaelite marked this pull request as ready for review December 14, 2021 15:07

remove unused methods

445bd0d

filiphr requested changes Dec 20, 2021

View reviewed changes

pass identity link ot interceptor when possible

e998ca6

tiffmaelite force-pushed the feature/rest-api-interceptors-for-identitylinks branch from fc42e6c to e998ca6 Compare December 20, 2021 16:11

filiphr and others added 2 commits December 20, 2021 18:19

Extract base methods for getting instance without invoking intercepto…

00b425e

…r and add interceptor of identity links for definitions

fix compilation issue

a295176

tiffmaelite commented Dec 21, 2021

View reviewed changes

rename methods + simplify implementation

eea0403

tiffmaelite force-pushed the feature/rest-api-interceptors-for-identitylinks branch from d14d395 to eea0403 Compare December 21, 2021 09:50

tiffmaelite requested a review from filiphr December 21, 2021 10:28

filiphr and others added 2 commits January 4, 2022 16:56

Do not do not needed access checks and rely on more specific access c…

87e7fe0

…hecks + add specific interception points for creating / updating / deleting variables

Merge branch 'main' into feature/rest-api-interceptors-for-identitylinks

961cab5

tiffmaelite changed the title ~~add REST API interceptors for handling permissions on identity links~~ add REST API interceptors for handling more diverse permissions (identity links, variables, conditional events) Apr 19, 2022

tiffmaelite force-pushed the feature/rest-api-interceptors-for-identitylinks branch 2 times, most recently from 494c4af to 71a21ab Compare March 3, 2023 10:17

tiffmaelite force-pushed the feature/rest-api-interceptors-for-identitylinks branch from 71a21ab to 72615b8 Compare March 3, 2023 10:19

tiffmaelite closed this May 4, 2023

Conversation

tiffmaelite commented Dec 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check List:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tiffmaelite commented Dec 13, 2021

Uh oh!

filiphr commented Dec 13, 2021

Uh oh!

tiffmaelite commented Dec 13, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tiffmaelite commented Dec 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

filiphr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tiffmaelite commented Apr 19, 2022

Uh oh!

tiffmaelite commented May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tiffmaelite commented Dec 10, 2021 •

edited

Loading