Handle deleting task candidates #3998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @JacekMiszczak. Can you perhaps add some test cases for this? |
Contributor
Author
|
Hey, @filiphr, I managed to find a good place to put those test cases in. |
JacekMiszczak
force-pushed
the
handle-task-candidate-delete
branch
from
e5c0b9e to
f185fba
Compare
Contributor
Author
|
Hey @filiphr, any update on this? Could we get this merged and released? |
Contributor
|
The PR looks good. I'd like to add the history checks as I believe that would showcase more why this was actually needed. Once I add that I'll merge the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle removal of task identity links by calling the appropriate methods from the task assignment manager, same as when adding identity links.
I haven't found any existing unit tests related to this functionality to modify and creating the entire test from scratch would be out of scope for this simple change. Please correct me if I'm wrong.
Check List: