Chore: use pattern variable #4114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @dbmalkovsky. This looks good to us. You can go ahead and upgrade all the occurrences when you have time |
Contributor
Author
|
@filiphr I think I found the remaining occurrences that needed updating. Thanks for the review. |
filiphr
reviewed
Sep 17, 2025
Contributor
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Thanks a lot @dbmalkovsky for this improvements.
While reviewing I found few places where we can do it a bit better. Have a look at my comments
...wable-engine/src/main/java/org/flowable/engine/impl/dynamic/AbstractDynamicStateManager.java
Outdated
Show resolved
Hide resolved
...wable-engine/src/main/java/org/flowable/engine/impl/dynamic/AbstractDynamicStateManager.java
Outdated
Show resolved
Hide resolved
...e-engine/src/main/java/org/flowable/engine/impl/dynamic/BaseDynamicSubProcessInjectUtil.java
Outdated
Show resolved
Hide resolved
...ne/src/main/java/org/flowable/engine/impl/persistence/entity/ExecutionEntityManagerImpl.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/org/flowable/variable/service/impl/types/JPAEntityListVariableType.java
Outdated
Show resolved
Hide resolved
…/dynamic/AbstractDynamicStateManager.java Co-authored-by: Filip Hrisafov <filip.hrisafov@gmail.com>
…/dynamic/AbstractDynamicStateManager.java Co-authored-by: Filip Hrisafov <filip.hrisafov@gmail.com>
…/dynamic/BaseDynamicSubProcessInjectUtil.java Co-authored-by: Filip Hrisafov <filip.hrisafov@gmail.com>
…ariable/service/impl/types/JPAEntityListVariableType.java Co-authored-by: Filip Hrisafov <filip.hrisafov@gmail.com>
per review comment
Contributor
|
Thanks a lot @dbmalkovsky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of JDK 16
Only modified a few files as an example (there are about 300 occurrences) to see if such a change is acceptable before I do all of them.