Add tests for IdentityLinkInterceptors and enhance SaveTaskCmds to ha… #4119
+807
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndle assignee and owner changes
Contributor
Author
|
I've made the behavior consistent and the IdentityLinkInterceptors are not now called when the task is unclaimed or the assignee is removed. |
tijsrademakers
pushed a commit
that referenced
this pull request
Sep 4, 2025
#4119) * Add tests for IdentityLinkInterceptors and enhance SaveTaskCmds to handle assignee and owner changes * Do not trigger IdentityLinkInterceptors when assignee or owner is removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to the SaveTaskCmds to trigger the IdentityLinkInterceptors in BPMN and CMMN when changing task assignee or task owner.
Added tests for all methods of the IdentityLinkInterceptors.
One additional note: I've noticed that in the process engine, when setting the task owner to null, the identity link interceptor is not executed. It is executed when setting the task assignee to null in the process engine, or when setting owner or assignee to null in the CMMN engine.
Process engine: https://github.com/flowable/flowable-engine/blob/main/modules/flowable-engine/src/main/java/org/flowable/engine/impl/util/TaskHelper.java#L302
CMMN engine: https://github.com/flowable/flowable-engine/blob/main/modules/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/impl/task/TaskHelper.java#L168
I've kept it for now, but might make sense to make behavior consistent.
Check List: