introduce MailClientProvider for dynamic mail client generation#4187
introduce MailClientProvider for dynamic mail client generation#4187filiphr merged 5 commits intoflowable:mainfrom
Conversation
2a06cd2 to
6f26cc8
Compare
filiphr
left a comment
There was a problem hiding this comment.
Thanks @vzickner. Looks good, I think we can do some small cleanups and maybe deprecate some of the old methods.
I've left some comments, the same comments are also valid for the BPMN counterparts.
Some other suggestions from a Claude Code Review:
-
BPMN
EmailTestCase.reinitilizeMailClients()should resetmailClientProviderUnlike the CMMN
CmmnEmailTestCase.reinitializeMailClients()which callssetMailClientProvider(null), the BPMN version does not. Works by coincidence currently but fragile. -
CmmnEmailTestCase.tearDown() restores provider then immediately overwrites it
tearDown()callssetMailClientProvider(initialMailClientProvider)followed byreinitializeMailClients()which callssetMailClientProvider(null). The restoration is dead code.
...src/main/java/org/flowable/cmmn/engine/impl/behavior/impl/mail/CmmnMailActivityDelegate.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public FlowableMailClient getMailClient(String tenantId) { | ||
| if (tenantId != null) { |
There was a problem hiding this comment.
I would use StringUtils.isNotBlank(tenantId) here. Reason is the fact that the empty tenant is null with Oracle, but empty string with other DBs.
...les/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/CmmnEngineConfiguration.java
Show resolved
Hide resolved
...les/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/CmmnEngineConfiguration.java
Show resolved
Hide resolved
...les/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/CmmnEngineConfiguration.java
Show resolved
Hide resolved
...les/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/CmmnEngineConfiguration.java
Show resolved
Hide resolved
modules/flowable-mail/src/main/java/org/flowable/mail/common/api/client/MailClientProvider.java
Outdated
Show resolved
Hide resolved
modules/flowable-mail/src/main/java/org/flowable/mail/common/api/client/MailClientProvider.java
Show resolved
Hide resolved
...les/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/CmmnEngineConfiguration.java
Outdated
Show resolved
Hide resolved
1868f9e to
c6776e8
Compare
add569c to
aba3b83
Compare
Check List: