fix query for suspended external worker jobs

modules/flowable-engine/src/test/java/org/flowable/engine/test/api/mgmt/JobQueryTest.java

@@ -342,6 +342,35 @@ public void testQueryByHandlerTypes() {
         managementService.deleteJob(managementService.createJobQuery().handlerType("Type2").singleResult().getId());
     }
 
+    @Test
+    public void testSuspendedJobQueryByType() {
+        String handlerType = "testSuspendedJobType";
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).count()).isEqualTo(0);
+
+        createSuspendedJobWithType(Job.JOB_TYPE_MESSAGE, handlerType);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).count()).isEqualTo(1);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).messages().count()).isEqualTo(1);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).timers().count()).isEqualTo(0);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).externalWorkers().count()).isEqualTo(0);
+
+        createSuspendedJobWithType(Job.JOB_TYPE_TIMER, handlerType);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).count()).isEqualTo(2);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).messages().count()).isEqualTo(1);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).timers().count()).isEqualTo(1);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).externalWorkers().count()).isEqualTo(0);
+
+        createSuspendedJobWithType(Job.JOB_TYPE_EXTERNAL_WORKER, handlerType);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).count()).isEqualTo(3);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).messages().count()).isEqualTo(1);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).timers().count()).isEqualTo(1);
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).externalWorkers().count()).isEqualTo(1);
+
+        managementService.deleteSuspendedJob(managementService.createSuspendedJobQuery().handlerType(handlerType).messages().singleResult().getId());
+        managementService.deleteSuspendedJob(managementService.createSuspendedJobQuery().handlerType(handlerType).timers().singleResult().getId());
+        managementService.deleteSuspendedJob(managementService.createSuspendedJobQuery().handlerType(handlerType).externalWorkers().singleResult().getId());
+        assertThat(managementService.createSuspendedJobQuery().handlerType(handlerType).count()).isEqualTo(0);
+    }
+
     @Test
     public void testSuspendedJobQueryByHandlerTypes() {
 
@@ -1131,6 +1160,18 @@ public Void execute(CommandContext commandContext) {
         });
     }
 
+    private void createSuspendedJobWithType(String type, String handlerType) {
+        managementService.executeCommand(commandContext -> {
+            JobServiceConfiguration jobServiceConfiguration = CommandContextUtil.getProcessEngineConfiguration(commandContext).getJobServiceConfiguration();
+            SuspendedJobEntityManager suspendedJobEntityManager = jobServiceConfiguration.getSuspendedJobEntityManager();
+            SuspendedJobEntity job = suspendedJobEntityManager.create();
+            job.setJobType(type);
+            job.setJobHandlerType(handlerType);
+            suspendedJobEntityManager.insert(job);
+            return null;
+        });
+    }
+
     private JobEntity createJobWithHandlerType(String handlerType) {
         CommandExecutor commandExecutor = processEngineConfiguration.getCommandExecutor();
         return commandExecutor.execute(new Command<>() {

modules/flowable-job-service/src/main/java/org/flowable/job/service/impl/SuspendedJobQueryImpl.java

@@ -347,7 +347,7 @@ public SuspendedJobQueryImpl externalWorkers() {
             throw new FlowableIllegalArgumentException("Cannot combine onlyTimers() with onlyExternalWorkers() in the same query");
         }
 
-        this.onlyTimers = true;
+        this.onlyExternalWorkers = true;
         return this;
     }