Skip to content

##4194 pass signal to the next subscribed listener#4195

Open
martin-grofcik wants to merge 4 commits intoflowable:mainfrom
martin-grofcik:#4194_pass-signal-for-suspended-process
Open

##4194 pass signal to the next subscribed listener#4195
martin-grofcik wants to merge 4 commits intoflowable:mainfrom
martin-grofcik:#4194_pass-signal-for-suspended-process

Conversation

@martin-grofcik
Copy link
Copy Markdown
Contributor

Check List:

  • Unit tests: YES
  • Documentation: NO

Copy link
Copy Markdown
Contributor

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-grofcik I'm not sure that I am following the changes here. I did not expect that startProcessInstanceByKey would work, since the definition is suspended.

What would perhaps make sense is in SignalEventReceivedCmd when there is no execution to ignore definitions that have been suspended and not swallow this in the SignalEventHandler

@martin-grofcik
Copy link
Copy Markdown
Contributor Author

martin-grofcik commented Mar 27, 2026

I did not expect that startProcessInstanceByKey would work, since the definition is suspended.

The suspended definition is processWithSignalStart1 and started process instance uses processWithSignalThrow, Quite common practice in this jUnit test. Can be changed to signalReceived(...)

What would perhaps make sense is in SignalEventReceivedCmd when there is no execution to ignore definitions that have been suspended and not swallow this in the SignalEventHandler

Requires more changes in the EventSubscription.xml. I can have a look.

@martin-grofcik
Copy link
Copy Markdown
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants