Remove historic entity link orphans on task, process and case deletion#4208
Merged
filiphr merged 1 commit intoflowable:mainfrom May 5, 2026
Merged
Conversation
Historic entity-link cleanup only deleted rows where the deleted entity appeared as the SCOPE_ID_, leaving orphan rows where it appeared as the REFERENCE_SCOPE_ID_. Subsequent reads of those links could return entries pointing at scopes that no longer exist. Add deleteHistoricEntityLinksByScopeIdOrReferenceScopeIdAndScopeType and bulkDeleteHistoricEntityLinksForScopeTypeAndScopeIdsOrReferenceScopeIds on HistoricEntityLinkService and use them from TaskHelper#deleteHistoricTask (BPMN and CMMN, single and bulk), DefaultHistoryManager#recordProcessInstanceDeleted / recordBulkDeleteProcessInstances, DefaultCmmnHistoryManager#recordHistoricCaseInstanceDeleted, and CmmnHistoryHelper#bulkDeleteHistoricCaseInstances. A single SQL delete now removes every row mentioning the deleted entity in either direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historic entity-link cleanup only deleted rows where the deleted entity appeared as the
SCOPE_ID_, leaving orphan rows where it appeared as theREFERENCE_SCOPE_ID_. Subsequent reads of those links could return entries pointing at scopes that no longer exist.Add
deleteHistoricEntityLinksByScopeIdOrReferenceScopeIdAndScopeTypeandbulkDeleteHistoricEntityLinksForScopeTypeAndScopeIdsOrReferenceScopeIdsonHistoricEntityLinkServiceand use them fromTaskHelper#deleteHistoricTask(BPMN and CMMN, single and bulk),DefaultHistoryManager#recordProcessInstanceDeleted/recordBulkDeleteProcessInstances,DefaultCmmnHistoryManager#recordHistoricCaseInstanceDeleted, andCmmnHistoryHelper#bulkDeleteHistoricCaseInstances. A single SQL delete now removes every row mentioning the deleted entity in either direction.