Conversation
📝 WalkthroughWalkthroughThe PR updates Helm chart source references in two Argo CD Application manifests, bumping the generic-charts targetRevision from v2.0.22 to v2.0.23 for both dependency-api and dependency-www deployments. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Argo diff output for dependency-api:===== datadoghq.com/DatadogMonitor datadog/dependency-api-errorrate ======
144d143
< - generated:kubernetes |
Argo diff output for dependency-www:===== datadoghq.com/DatadogMonitor datadog/dependency-www-errorrate ======
144d143
< - generated:kubernetes |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
deploy/dependency-api/app.yaml (1)
45-47: Same chart bump as dependency-www; ensure verification covers this app too.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deploy/dependency-api/app.yaml` around lines 45 - 47, The chart version for the app at path "charts/flow-generic" was bumped (targetRevision: v2.0.23) like dependency-www but verification wasn't updated; update the deployment verification to include this app by adding or extending the existing check for dependency-www to also validate the chart at path "charts/flow-generic" (targetRevision) — ensure your CI/build/test job verifies the new targetRevision v2.0.23 is deployed and that any smoke/integration tests used for dependency-www also run against this app.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@deploy/dependency-api/app.yaml`:
- Around line 45-47: The chart version for the app at path "charts/flow-generic"
was bumped (targetRevision: v2.0.23) like dependency-www but verification wasn't
updated; update the deployment verification to include this app by adding or
extending the existing check for dependency-www to also validate the chart at
path "charts/flow-generic" (targetRevision) — ensure your CI/build/test job
verifies the new targetRevision v2.0.23 is deployed and that any
smoke/integration tests used for dependency-www also run against this app.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
v2.0.22->v2.0.23Before merging:
Ensure your service is compatible with the new chart version
Review diff in PR with changes
Merge when ready to deploy this change
After merging, ArgoCD will automatically sync the new chart version.
Release Notes
flowcommerce/generic-charts (git@github.com:flowcommerce/generic-charts.git)
v2.0.23Compare Source
This PR has been generated by Renovate Bot.
Summary by CodeRabbit