Skip to content

feat(exec): show container config in executable detail views#410

Merged
jahvon merged 1 commit into
mainfrom
jdoc/feat-container-exec-view
Jul 23, 2026
Merged

feat(exec): show container config in executable detail views#410
jahvon merged 1 commit into
mainfrom
jdoc/feat-container-exec-view

Conversation

@jahvon

@jahvon jahvon commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to the containerized-executions feature (#407): neither executable detail view surfaced the container: config.

  • flow get (markdown) — shellExecMarkdown rendered dir/logMode/cmd/file but not container.
  • flow browse (TUI detail) — shellExecConfig had the same gap.

Adds a shared executable.ContainerConfigMarkdown renderer and wires it into both paths, so image, runtime, workspace mount, volumes, user, network, and entrypoint are shown. Effective values are displayed, so SetDefaults-applied fields (runtime auto, mount /workspace) are visible.

Example rendered block:

**Container**
- Image: `golang:1.21-alpine`
- Runtime: auto
- Workspace mount: `/workspace`
- Volume: `//cache:/cache`
- User: `1000:1000`
- Network: `host`
- Entrypoint: image default

Testing

  • Unit test for ContainerConfigMarkdown (nil → empty; all fields present; entrypoint: "" → "image default").
  • Verified the full Executable.Markdown() path includes the block.
  • Full unit suite + lint clean.

🤖 Generated with Claude Code

Neither the markdown renderer (flow get) nor the TUI detail view
(flow browse) surfaced a container block. Add a shared
ContainerConfigMarkdown renderer in the types package and wire it into
both shellExecMarkdown and shellExecConfig so image, runtime, mounts,
volumes, user, network, and entrypoint are visible.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
types/executable/container.go 76.92% 3 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@jahvon
jahvon merged commit b34d95f into main Jul 23, 2026
15 checks passed
@jahvon
jahvon deleted the jdoc/feat-container-exec-view branch July 23, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant