Skip to content

build(deps): bump tuikit to v0.4.1 for logger data-race fix#415

Merged
jahvon merged 1 commit into
mainfrom
fix/logger-writer-datarace
Jul 26, 2026
Merged

build(deps): bump tuikit to v0.4.1 for logger data-race fix#415
jahvon merged 1 commit into
mainfrom
fix/logger-writer-datarace

Conversation

@jahvon

@jahvon jahvon commented Jul 26, 2026

Copy link
Copy Markdown
Member

Summary

Bumps tuikit v0.4.0v0.4.1, which fixes the logger data race at the source (flowexec/tuikit#112) instead of working around it in flow.

The race was between a command's stdout and stderr streams (copied by os/exec in separate goroutines) both flipping StandardLogger's shared mode field. tuikit v0.4.1:

  • guards the mode field with a mutex,
  • serializes the writers' flip/render/restore sequence, and
  • fixes StdOutWriter never restoring the mode after a flip.

Since the fix lives in the dependency, no client-side change is needed here beyond the version bump — this PR previously carried a syncWriter workaround, now removed in favor of the upstream fix.

Testing

  • flow validate passes (generate → lint → unit + e2e → schemas).
  • Race coverage lives upstream in tuikit's output_race_test.go.

🤖 Generated with Claude Code

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

tuikit v0.4.1 makes StandardLogger's mode concurrency-safe and fixes the
Std{Out,Err}Writer restore path (flowexec/tuikit#112). That resolves the data
race between a command's concurrently-copied stdout and stderr streams at the
source, so no client-side workaround is needed here.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@jahvon
jahvon force-pushed the fix/logger-writer-datarace branch from 49088ce to 3661996 Compare July 26, 2026 15:06
@jahvon jahvon changed the title fix(run): serialize stdout/stderr writers to fix logger data race build(deps): bump tuikit to v0.4.1 for logger data-race fix Jul 26, 2026
@jahvon
jahvon merged commit da3e6f5 into main Jul 26, 2026
19 checks passed
@jahvon
jahvon deleted the fix/logger-writer-datarace branch July 26, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant