Skip to content

Conversation

@roibeart
Copy link

When generating a unique filename, by default the generateUniqueIdentifier creates a filename replacing also the dots inside the relative path, so the resulting filename doesn't have an extension: this can be annoying, so I propose to keep the dots of the original filename when creating the unique identifier.

When generating a unique filename, by default the generateUniqueIdentifier creates a filename replacing also the dots inside the relative path, so the resulting filename doesn't have an extension: this can be annoying, so I propose to keep the dots of the original filename when creating the unique identifier.
@evilaliv3
Copy link
Member

evilaliv3 commented Sep 29, 2016 via email

@AidasK
Copy link
Member

AidasK commented Sep 29, 2016

Unique identifier is not a file name. It is not intended to be used as such. You can access original file name on the serverside and save it in any way you want.

@roibeart
Copy link
Author

Ok, it seems reasonable to me.
Anyway, I made this pull request after using the flow.js php server library and noting that in the getting started example the name of the file to be stored in the server is created by using the getIdentifier() method, which returns a string generated by the generateUniqueIdentifier function (resulting in a filename without the extension).
Maybe just changing the code of the example could be a solution.

@blhagadorn
Copy link

@roibeart The uniqueIdentifier is really for cases where you might be sending your file(s) to a load-balanced server. Then you'd want to make sure you route all of the chunks to that specific server so you can put the chunks together rather than have them dispersed. Just posting that as an FYI. Correct me if I'm wrong anyone!

@roibeart
Copy link
Author

roibeart commented Nov 1, 2017

I edited the README file of flowjs/flow-php-server in order to avoid the use of the getIdentifier() method, so there is no need anymore for this pull request: I'm closing it.

@roibeart roibeart closed this Nov 1, 2017
@roibeart roibeart deleted the patch-1 branch November 1, 2017 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants