optimise spikes to times sorting#306
Merged
jamesb93 merged 1 commit intoflucoma:mainfrom Jun 10, 2025
Merged
Conversation
jamesb93
force-pushed
the
enhance/optimise-spikestotimes
branch
from
e770cc9 to
2095391
Compare
tremblap
approved these changes
Jun 10, 2025
Member
tremblap
left a comment
tremblap
left a comment
There was a problem hiding this comment.
this yields the same results in all UTs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix makes the sorting in this part of spikesToTimes much faster, for reasons...