docs: administration: document input rate metrics and rate gate - #2637
docs: administration: document input rate metrics and rate gate#2637eschabell wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe documentation adds input ingestion-rate metrics, optional rate-gate configuration, rate-gate behavior, and five V2 Prometheus metrics. ChangesInput rate documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@administration/configuring-fluent-bit/yaml/pipeline-section.md`:
- Line 99: Update the gate behavior description to explain the combined-limit
semantics: pausing occurs when either the byte-rate or record-rate limit is
exceeded, and resumption requires both measured rates to fall below their
respective effective limits multiplied by rate_gate.resume_ratio.
- Line 97: Update the rate gate activation wording near the rate_gate
configuration description to state that rate_gate must be enabled and at least
one of rate_gate.max_bytes or rate_gate.max_records must be set to a non-zero
value; preserve that zero means unlimited.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: be8a90a6-52e4-4804-8bd1-619b83cdca10
📒 Files selected for processing (2)
administration/configuring-fluent-bit/yaml/pipeline-section.mdadministration/monitoring.md
62885b2 to
047e6d3
Compare
|
@patrick-stephens ready for review! |
Add the rate_window and rate_gate settings shared by all input plugins to the pipeline section, covering the pause and resume thresholds and how backpressure scales the effective limit. Add the five new fluentbit_input_rate_* metrics to the monitoring reference. Also clarify rate gate pause and resume semantics and rate gate activation requirements. Note: this update needed to cover code changes without doc PR Signed-off-by: Eric D. Schabell <eric@schabell.org>
…example Signed-off-by: Eric D. Schabell <eric@schabell.org>
047e6d3 to
347afbb
Compare
|
@patrick-stephens fixed conflicts, back to you for review. |
Add the rate_window and rate_gate settings shared by all input plugins to the pipeline section, covering the pause and resume thresholds and how backpressure scales the effective limit. Add the five new fluentbit_input_rate_* metrics to the monitoring reference.
Note: this update needed to cover code changes without doc PR
Summary by CodeRabbit