Skip to content

skills: Extract skills from memory#12068

Merged
edsiper merged 3 commits into
masterfrom
cosmo0920-extract-skills-from-memory.md
Jul 8, 2026
Merged

skills: Extract skills from memory#12068
edsiper merged 3 commits into
masterfrom
cosmo0920-extract-skills-from-memory.md

Conversation

@cosmo0920

@cosmo0920 cosmo0920 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

In these days, we're heavily relying on LLMs to develop various features and bug fixes on Windows and macOS platforms.
At the moment, we need to extract our locally stored knowledge on our LLM agents.
In this PR, I added generalized skills from my local agents and slightly modified for Windows exceptions due to lack of runtime testing support on Windows.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Documentation
    • Added a new index for repository skill bundles and a Fluent Bit-specific skill overview.
    • Introduced several new guidance docs covering workflow, pipeline architecture, subsystem troubleshooting, and testing/verification.
    • Expanded contribution instructions with clearer Windows test handling, bundled-library editing rules, and PR/commit validation guidance.

@cosmo0920 cosmo0920 requested a review from edsiper as a code owner July 7, 2026 05:56
@cosmo0920 cosmo0920 added this to the Fluent Bit v5.1 milestone Jul 7, 2026
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates AGENTS.md with Windows-specific runtime test skipping guidance, bundled library edit restrictions, and commit lint clarifications. It also adds a new skills/ directory containing an index README and a comprehensive Fluent Bit skill bundle with documentation covering testing, patch workflow, pipeline architecture, and subsystem patterns.

Changes

AGENTS.md Windows and Contribution Guidance

Layer / File(s) Summary
Windows runtime test skip and bundled-library rules
AGENTS.md
Adds Windows-specific instructions across Preferred Commands, build/test configuration, Testing Guidelines, close-out proof, commit lint workflow, Agent Action Limits, and Testing strategy sections to skip runtime tests on Windows using -DFLB_TESTS_RUNTIME=Off, avoid unconfirmed edits to bundled lib/ code, and clarify commit-lint base-ref fallback behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

New Fluent Bit Skills Documentation

Layer / File(s) Summary
Skills index and README
skills/README.md, skills/fluent-bit/README.md
Adds a top-level index page describing the skill bundle directory structure and a Fluent Bit-specific README listing included documents and a suggested agent prompt.
SKILL.md entrypoint
skills/fluent-bit/SKILL.md
Adds the primary skill document defining usage conditions, required reading order, operating principles, build/test/verification commands, and close-out response requirements.
Testing guide
skills/fluent-bit/testing.md
Adds documentation for test selection, Windows runtime test exceptions, integration test expectations, blocker reporting, validation habits, and close-out proof format.
Patch workflow guide
skills/fluent-bit/patch-workflow.md
Adds pre-edit checklist, implementation rules, review stance, and commit guidance documentation.
Pipeline architecture guide
skills/fluent-bit/pipeline-architecture.md
Adds documentation on pipeline data flow, component responsibilities, metrics/counting distinctions, retry/drop semantics, and a review checklist.
Subsystem patterns guide
skills/fluent-bit/subsystem-patterns.md
Adds troubleshooting patterns and search guidance across config maps, node exporter, rewrite tag/emitter backlog, Kubernetes filtering, scheduler/shutdown, eBPF OpenSSL, Kafka Avro, and Avro encoder subsystems.

Estimated code review effort: 1 (Trivial) | ~10 minutes

Possibly related PRs

  • fluent/fluent-bit#11644: Both PRs modify AGENTS.md contribution guidance, with this PR expanding Windows runtime-test skip requirements and bundled-lib isolation details built on the AGENTS.md introduced there.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding generalized skills extracted from local memory into the repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-extract-skills-from-memory.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 692c24a2df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/fluent-bit/patch-workflow.md
Comment thread skills/fluent-bit/testing.md
@cosmo0920 cosmo0920 force-pushed the cosmo0920-extract-skills-from-memory.md branch from 692c24a to c0c82cb Compare July 7, 2026 06:04
cosmo0920 added 3 commits July 7, 2026 15:12
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920 cosmo0920 force-pushed the cosmo0920-extract-skills-from-memory.md branch from 077ecd7 to 11625e0 Compare July 7, 2026 06:12

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
skills/fluent-bit/testing.md (1)

42-49: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Prefer run_tests.py as the primary integration example.

The raw pytest invocation bypasses the repo's integration wrapper, which already handles --valgrind, --valgrind-strict, FLUENT_BIT_BINARY, and the expected collection/progress flow. Swapping this block to the wrapper keeps the guide aligned with the documented harness.

♻️ Suggested edit
- tests/integration/.venv/bin/python -m pytest <focused-scenario> -q
- VALGRIND=1 VALGRIND_STRICT=1 \
-   tests/integration/.venv/bin/python -m pytest <focused-scenario> -q
+ ./run_tests.py <focused-scenario>
+ ./run_tests.py --valgrind --valgrind-strict <focused-scenario>

Based on learnings, run the in-tree Python integration suite from tests/integration using ./setup-venv.sh and ./run_tests.py.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/fluent-bit/testing.md` around lines 42 - 49, The integration testing
example should use the repo’s wrapper instead of calling pytest directly. Update
the `testing.md` guidance around the integration flow to show
`tests/integration/run_tests.py` as the primary entry point, while keeping the
venv setup and build steps, so the documented harness covers `--valgrind`,
`--valgrind-strict`, `FLUENT_BIT_BINARY`, and the expected collection/progress
behavior.

Source: Learnings

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@skills/fluent-bit/testing.md`:
- Around line 42-49: The integration testing example should use the repo’s
wrapper instead of calling pytest directly. Update the `testing.md` guidance
around the integration flow to show `tests/integration/run_tests.py` as the
primary entry point, while keeping the venv setup and build steps, so the
documented harness covers `--valgrind`, `--valgrind-strict`,
`FLUENT_BIT_BINARY`, and the expected collection/progress behavior.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 752f3ef1-fadf-4afd-8404-6c23df183d8f

📥 Commits

Reviewing files that changed from the base of the PR and between 46e15a1 and 11625e0.

📒 Files selected for processing (8)
  • AGENTS.md
  • skills/README.md
  • skills/fluent-bit/README.md
  • skills/fluent-bit/SKILL.md
  • skills/fluent-bit/patch-workflow.md
  • skills/fluent-bit/pipeline-architecture.md
  • skills/fluent-bit/subsystem-patterns.md
  • skills/fluent-bit/testing.md

@edsiper edsiper merged commit f2ab78d into master Jul 8, 2026
70 of 74 checks passed
@edsiper edsiper deleted the cosmo0920-extract-skills-from-memory.md branch July 8, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants