out_azure_blob: increase buffer path buffer size#12138
Open
locker95 wants to merge 1 commit into
Open
Conversation
buffer_dir and azure_blob_buffer_key are joined into a fixed stack buffer in azure_blob_store_init(). Size 64 truncates longer paths; use 1024 and keep snprintf bounds via sizeof(tmp). Fixes fluent#12062 Signed-off-by: Dean Chen <862469039@qq.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Azure Blob store initialization increases its temporary path buffer from 64 to 1024 bytes when composing storage directory and stream names. ChangesAzure Blob buffer sizing
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
azure_blob_store_init(),buffer_dirandazure_blob_buffer_keyare joined into a fixed stack buffer before callingflb_fstore_create(). That buffer was only 64 bytes, so longer directory paths were truncated viasnprintf.Increase the buffer to 1024 bytes (common path-sized stack buffers elsewhere in the tree). Bounds remain enforced with
snprintf(..., sizeof(tmp), ...).Fixes #12062
Changes
plugins/out_azure_blob/azure_blob_store.c:char tmp[64]→char tmp[1024]Testing
snprintf/strftimecall sites already usesizeof(tmp).Checklist
Summary by CodeRabbit