feat: adjust fluentbit service helm value to allow specifying all possible service fields#2010
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the charts/fluent-operator Helm chart to make Fluent Bit service configuration more flexible by passing through user-provided fluentbit.service values into the rendered ClusterFluentBitConfig resources.
Changes:
- Switch Fluent Bit config templates to render
.Values.fluentbit.serviceviatoYaml, enabling arbitraryservicefields to be specified through values. - Adjust
values.yamlto avoid a non-empty defaultservicemap (by removing the defaultstorage: {}) that would otherwise render unintended defaults.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/fluent-operator/values.yaml | Removes default service.storage: {} and updates the commented example for service storage config. |
| charts/fluent-operator/templates/fluentbitconfig-fluentBitConfig.yaml | Renders fluentbit.service into spec.service to support additional service fields. |
| charts/fluent-operator/templates/fluentbitconfig-fluentbitconfig-edge.yaml | Renders fluentbit.service into spec.service for the edge config. |
…ossible service fields Signed-off-by: Dylan Jenik <dylanjenikcodes@gmail.com>
Comment on lines
526
to
+533
| service: | ||
| # Scheduler configuration for retry wait times (supported in Fluent Bit >= 1.8.7) | ||
| # -- Scheduler base for exponential backoff (seconds) | ||
| # schedulerBase: 5 | ||
| # -- Scheduler cap for maximum retry time (seconds) | ||
| # schedulerCap: 2000 | ||
| # -- Storage configuration for Fluent Bit buffering | ||
| storage: {} | ||
| # Remove the above storage section and uncomment below section if you want to configure file-system as storage for buffer | ||
| # storage: | ||
| # path: "/host/fluent-bit-buffer/" | ||
| # backlogMemLimit: "50MB" | ||
| # checksum: "off" | ||
| # deleteIrrecoverableChunks: "on" | ||
| # maxChunksUp: 128 | ||
| # metrics: "on" | ||
| # sync: normal | ||
| # storage: |
joshuabaird
changed the title
service helm value to allow specifying all p…service helm value to allow specifying all possible service fields
Collaborator
|
@eatmyrust Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ossible service fields
What this PR does / why we need it:
Allows users of the helm chart to specify any possible fluentbit
serviceconfiguration, rather than only the fields that the chart explicitly exposes through values. This will reduce future maintenance of the helm chart by not requiring chart maintainers to add every possibleserviceconfiguration value into the helm chart.Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: