Skip to content

Apply additional honkit migration - #672

Merged
Watson1978 merged 4 commits into
1.0from
honkit-followup
Aug 10, 2026
Merged

Apply additional honkit migration#672
Watson1978 merged 4 commits into
1.0from
honkit-followup

Conversation

@kenhys

@kenhys kenhys commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Follow-up #671

kenhys added 4 commits August 10, 2026 11:15
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@netlify

netlify Bot commented Aug 10, 2026

Copy link
Copy Markdown

Deploy Preview for fluentd-docs ready!

Name Link
🔨 Latest commit a126838
🔍 Latest deploy log https://app.netlify.com/projects/fluentd-docs/deploys/6a7936390ef67f00082c2771
😎 Deploy Preview https://deploy-preview-672--fluentd-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kenhys
kenhys requested a review from Watson1978 August 10, 2026 02:24

@Watson1978 Watson1978 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Watson1978
Watson1978 merged commit 98e7fab into 1.0 Aug 10, 2026
6 checks passed
@Watson1978
Watson1978 deleted the honkit-followup branch August 10, 2026 02:39
kenhys pushed a commit that referenced this pull request Aug 10, 2026
HonKit builds heading ids differently from GitBook: it drops backticks,
`<`, `>` and `_` from the heading text. The links written for GitBook
therefore stopped resolving once #671 and #672 made HonKit the renderer
for the published site.

| heading                     | GitBook id                             | HonKit id      |
| --------------------------- | -------------------------------------- | -------------- |
| `### `add_http_headers``    | add_http_headers                       | addhttpheaders |
| `### `<inject>` Section`    | less-than-inject-greater-than-section  | inject-section |

15 links across 6 files, 8 distinct anchors:

* input/http.md               #add_http_headers, #decompression_size_limit
* input/syslog.md             #source_host_key
* output/http.md              #allowed_hosts
* output/exec_filter.md       #less-than-{inject,extract}-greater-than-section
* output/file.md              #less-than-buffer-greater-than-section
* deployment/system-config.md #less-than-source_only_buffer-greater-than-section

Verified by building the site with the repository's own configuration and
matching every `href="#..."` against the `id=` and `name=` attributes on
the same page. Before this change 8 of the 2366 in-page anchors did not
resolve; after it, none are left.

The new ids were read out of the generated HTML rather than derived from
the rule by hand.

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants