Update Rails to 5.2.0 #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2018
Closed
Closed
TODO: I will update Capybara to 3.x after I update Rails 5.2.x Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
FactoryGirl -> FactoryBot Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
But I removed ActiveRecord related entries because we don't use ActiveRecord. Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
> DEPRECATION WARNING: ActiveModel::Errors#get is deprecated and will be > removed in Rails 5.1. To achieve the same use > model.errors[:config_file]. Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
> DEPRECATION WARNING: `config.static_cache_control` is deprecated and
> will be removed in Rails 5.1. Please use
> `config.public_file_server.headers = { 'Cache-Control' => 'public,
> max-age=3600' }` instead.
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
> DEPRECATION WARNING: `config.serve_static_files` is deprecated and > will be removed in Rails 5.1. Please use > `config.public_file_server.enabled = true` instead. Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
> I18n::InvalidLocale: "ja" is not a valid locale Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
> DEPRECATION WARNING: `render :text` is deprecated because it does not > actually render a `text/plain` response. Switch to `render plain: > 'plain text'` to render as `text/plain`, `render html: > '<strong>HTML</strong>'` to render as `text/html`, or `render body: > 'raw'` to match the deprecated behavior and render with the default > Content-Type, which is `text/html`. Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
> DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
> in favor of keyword arguments, and will be removed in Rails 5.1.
>
> Deprecated style:
> get :show, { id: 1 }, nil, { notice: "This is a flash message" }
>
> New keyword style:
> get :show, params: { id: 1 }, flash: { notice: "This is a flash message" },
> session: nil # Can safely be omitted.
> DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
> in favor of keyword arguments, and will be removed in Rails 5.1.
>
> Deprecated style:
> get :show, { id: 1 }, nil, { notice: "This is a flash message" }
>
> New keyword style:
> get :show, params: { id: 1 }, flash: { notice: "This is a flash message" },
> session: nil # Can safely be omitted.
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
> DEPRECATION WARNING: `redirect_to :back` is deprecated and will be > removed from Rails 5.1. Please use `redirect_back(fallback_location: > fallback_location)` where `fallback_location` represents the location > to use if the request has no HTTP referer information. Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Update following gems: * capybara to 3.0.2 * capybara-screenshot to 1.0.19 * remove poltergeist * add selenium-webdriver Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
> RuntimeError Circular dependency detected while autoloading constant Plugin Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Because Rails 5 drops Ruby 2.1 support. Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
See https://docs.travis-ci.com/user/gui-and-headless-browsers/#Ruby Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
$ google-chrome-stable --version
Google Chrome 62.0.3202.94
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Contributor
Author
|
I will start developing Fluentd v1 support after merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #222