feat(Console): improve command history navigation#1843
Merged
pedrolamas merged 1 commit intoMay 15, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the console command history navigation to support multi-line entries: arrow keys only navigate history when the cursor is on the first/last line of the textarea, and a single historyIndex replaces the previous rotating-array approach, naturally allowing blank "sentinel" entries above the newest and below the oldest history items.
Changes:
- Replaced the
historyrotation +originalHistory/isFirststate with a simplehistoryIndexcursor over a stablehistoryarray. - New
handleKeyUp/handleKeyDownonly intercept arrow keys when the caret is on the first/last visual line (no\nbefore/after caret and no selection), allowing in-entry caret movement otherwise. - Updated the
inputref type fromVTextFieldtoVTextareato access the underlying textarea element via$refs.input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve keyboard navigation on the console, allowing changing line when a multi-line entry is currently showed.
Current behavior is now to also include a blank entry on the top and on the bottom of history.