test: standalone it_minmax bin + aws-gate smoke_minio (vbench follow-ups)#1486
Open
aaj3f wants to merge 3 commits into
Open
test: standalone it_minmax bin + aws-gate smoke_minio (vbench follow-ups)#1486aaj3f wants to merge 3 commits into
aaj3f wants to merge 3 commits into
Conversation
…feature it_minmax_fast_path_fired documents that its thread-local set_default tracing capture requires being the only test in its binary, but the grp_* consolidation bundled it into grp_misc with 241 siblings — parallel interleaving flips its event capture (surfaced during the PR-2 gates). A process-global subscriber is NOT a sound fix here: the test asserts the ABSENCE of 'fast path declined; running fallback', which siblings also emit from the shared aggregate fast path, so global capture would false-fail nondeterministically. Restore the standalone [[test]] bin (matches the existing it_cyclic_bgp_probe convention). Full api suite green; standalone bin passes; grp_misc passes in parallel. smoke_minio needs the aws-gated S3IcebergStorage: mark the example required-features=["aws"] so bare cargo test -p fluree-db-iceberg is green. Also closes the PR-2-era q009/q010 native perf flags as environmental: idle-machine 5-rep recheck = 1.10x / 1.03x vs blessed (was ~2.3x under concurrent build load).
…to chore/vbench-followups
…e note (review follow-up) The #1486 review's one optional code item: the header documented BOTH interference mechanisms but not their scope, leaving the rationale open to a false disproof ("nextest-run bundled siblings don't interfere"). Both mechanisms are process-scoped — callsite-interest cache poisoning and sibling decline-event capture bite under thread-parallel cargo test (one shared process), not under nextest's process-per-test model. The standalone bin keeps the test sound under both runners, and cargo test is what contributors reach for first. Also from the review: the surfaced binary-index reload flake is now filed as #1489 (was "issue-filing decision with AJ" in the PR body; body updated with the number). Gates: standalone bin 1/1; cargo fmt --all --check green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-infra follow-ups from the perf-series gate batteries (no engine code):
it_minmax_fast_path_fired→ standalone test bin. Its thread-localset_defaultcapture requires sole ownership of the process (its own doc says so); thegrp_*consolidation bundled it with 241 siblings and parallel interleaving flips its event capture (bit us in the PR-2 gates). A process-global subscriber is unsound here — the test asserts the absence of the shared fast-path decline event, which siblings also emit → nondeterministic false-fail under global capture. Standalone bin matches the existingit_cyclic_bgp_probeconvention. Full api suite green; parallelgrp_miscgreen.smoke_miniogated onrequired-features=["aws"]— barecargo test -p fluree-db-icebergis now green (was failing to compile the example under default features; pre-existing, proven by stash-to-base during PR-1 gates).Separate pre-existing flake surfaced (NOT addressed here, out of scope):
it_values_type_deleted_repro::values_bound_type_after_delete_incremental_index_timelinefails ~1/6 parallelgrp_miscruns withInternal("failed to load binary index: dict branch: too small for header")— a binary-index reload race, passes single-threaded, structurally unrelated to these edits. Flagged for the binary-index owner; filed as #1489.Stacks on #1482 (PR-2); orthogonal to PR-3/4/4b (no file overlap).