Skip to content

Conversation

@swift-kim
Copy link
Member

  • Remove headed engine tests, because they cannot be run without a display attached.
  • Add the test job to the CI pipelines.

EXPECT_TRUE(engine_->GetTextureRegistrar() == nullptr);
}

TEST_F(FlutterTizenEngineTestHeaded, GetTextureRegistrar) {
Copy link
Member

@bwikbs bwikbs Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just disable it instead of removing it? This TC doesn't mean much, but I want to keep the TC with the renderer enabled.

- publish: $(Build.StagingDirectory)
artifact: $(System.JobName)
- job: release
- job: test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to do this when a github action is enable, but you do it right away! 👍 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was as simple as installing EFL on the CI server and adding 20 lines of code. :)

Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty cool! thanks!

@swift-kim
Copy link
Member Author

I don't know why but apparently the incremental builds take longer than before (1 min → 3-4 min).

@swift-kim swift-kim merged commit 342691b into flutter-tizen:flutter-2.2.1-tizen Jul 23, 2021
swift-kim added a commit that referenced this pull request Sep 27, 2021
* Disable headed tests

* Run unittests in the CI

* Revert "Disable headed tests"

This reverts commit b92e76f.

* Disable test GetTextureRegistrar

* Replace gclient sync with git checkout

* Separate the run step
swift-kim added a commit that referenced this pull request Nov 14, 2021
* Disable headed tests

* Run unittests in the CI

* Revert "Disable headed tests"

This reverts commit b92e76f.

* Disable test GetTextureRegistrar

* Replace gclient sync with git checkout

* Separate the run step
swift-kim added a commit that referenced this pull request Dec 9, 2021
* Disable headed tests

* Run unittests in the CI

* Revert "Disable headed tests"

This reverts commit b92e76f.

* Disable test GetTextureRegistrar

* Replace gclient sync with git checkout

* Separate the run step
swift-kim added a commit that referenced this pull request Dec 17, 2021
* Run unittests in the CI

* Disable test GetTextureRegistrar

* Replace gclient sync with git checkout

* Separate the run step
swift-kim added a commit that referenced this pull request Feb 7, 2022
* Run unittests in the CI

* Disable test GetTextureRegistrar

* Replace gclient sync with git checkout

* Separate the run step
swift-kim added a commit that referenced this pull request Feb 11, 2022
* Run unittests in the CI

* Disable test GetTextureRegistrar

* Replace gclient sync with git checkout

* Separate the run step
swift-kim added a commit that referenced this pull request May 12, 2022
* Run unittests in the CI

* Disable test GetTextureRegistrar

* Replace gclient sync with git checkout

* Separate the run step
swift-kim added a commit that referenced this pull request Aug 5, 2022
* Run unittests in the CI

* Disable test GetTextureRegistrar

* Replace gclient sync with git checkout

* Separate the run step
swift-kim added a commit that referenced this pull request Sep 1, 2022
* Run unittests in the CI

* Disable test GetTextureRegistrar

* Replace gclient sync with git checkout

* Separate the run step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants