Skip to content

Automated unit testing #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 23, 2021
Merged

Automated unit testing #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b92e76f
Disable headed tests
swift-kim Jul 21, 2021
7c9b8b6
Run unittests in the CI
swift-kim Jul 21, 2021
1eda0d8
Revert "Disable headed tests"
swift-kim Jul 21, 2021
c33e471
Disable test GetTextureRegistrar
swift-kim Jul 21, 2021
40ce6e1
Replace gclient sync with git checkout
swift-kim Jul 21, 2021
34bfefe
Separate the run step
swift-kim Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,32 @@ jobs:
failOnStderr: true
- publish: $(Build.StagingDirectory)
artifact: $(System.JobName)
- job: release
- job: test
Copy link
Member

@bwikbs bwikbs Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to do this when a github action is enable, but you do it right away! 👍 👍

Copy link
Member Author

@swift-kim swift-kim Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was as simple as installing EFL on the CI server and adding 20 lines of code. :)

dependsOn: build
pool:
name: Default
demands: agent.os -equals Linux
timeoutInMinutes: 20
cancelTimeoutInMinutes: 1
steps:
- checkout: self
path: src/flutter
- bash: |
git checkout -- build/config/compiler/BUILD.gn
flutter/tools/gn \
--no-goma \
--runtime-mode debug \
--enable-fontconfig \
--build-tizen-shell
ninja -C out/host_debug
displayName: Build unittests
workingDirectory: $(Pipeline.Workspace)/src
failOnStderr: true
- bash: out/host_debug/flutter_tizen_unittests
displayName: Run
workingDirectory: $(Pipeline.Workspace)/src
- job: release
dependsOn: test
pool:
name: Default
demands: agent.os -equals Linux
Expand Down
3 changes: 2 additions & 1 deletion shell/platform/tizen/flutter_tizen_engine_unittest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ TEST_F(FlutterTizenEngineTest, GetTextureRegistrar) {
EXPECT_TRUE(engine_->GetTextureRegistrar() == nullptr);
}

TEST_F(FlutterTizenEngineTestHeaded, GetTextureRegistrar) {
Copy link
Member

@bwikbs bwikbs Jul 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just disable it instead of removing it? This TC doesn't mean much, but I want to keep the TC with the renderer enabled.

// Disabled for headless testing.
TEST_F(FlutterTizenEngineTestHeaded, DISABLED_GetTextureRegistrar) {
EXPECT_TRUE(engine_->RunEngine(nullptr));
EXPECT_TRUE(engine_->GetTextureRegistrar() != nullptr);
}
Expand Down