Refactor AppControl and AppControlChannel #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-kim
force-pushed
the
app-control-refactor
branch
from
5d9f2e7 to
a3d5ff2
Compare
swift-kim
force-pushed
the
app-control-refactor
branch
from
7911a37 to
3d78d3f
Compare
bbrto21
approved these changes
Sep 23, 2021
swift-kim
added a commit
that referenced
this pull request
Sep 27, 2021
* Refactor app_control_channel * Refactor app_control * Fix reply bug * Allow null values * Revert "Allow null values" This reverts commit bbbc1c7. * Check empty strings * Inline Create and Dispose
swift-kim
added a commit
that referenced
this pull request
Nov 14, 2021
* Refactor app_control_channel * Refactor app_control * Fix reply bug * Allow null values * Revert "Allow null values" This reverts commit bbbc1c7. * Check empty strings * Inline Create and Dispose
swift-kim
added a commit
that referenced
this pull request
Dec 9, 2021
* Refactor app_control_channel * Refactor app_control * Fix reply bug * Allow null values * Revert "Allow null values" This reverts commit bbbc1c7. * Check empty strings * Inline Create and Dispose
swift-kim
added a commit
that referenced
this pull request
Dec 17, 2021
* Refactor app_control_channel * Refactor app_control * Fix reply bug * Check empty strings * Inline Create and Dispose
swift-kim
added a commit
that referenced
this pull request
Feb 7, 2022
* Refactor app_control_channel * Refactor app_control * Fix reply bug * Check empty strings * Inline Create and Dispose
swift-kim
added a commit
that referenced
this pull request
Feb 11, 2022
* Refactor app_control_channel * Refactor app_control * Fix reply bug * Check empty strings * Inline Create and Dispose
swift-kim
added a commit
that referenced
this pull request
May 12, 2022
* Refactor app_control_channel * Refactor app_control * Fix reply bug * Check empty strings * Inline Create and Dispose
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
* Refactor app_control_channel * Refactor app_control * Fix reply bug * Check empty strings * Inline Create and Dispose
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
* Refactor app_control_channel * Refactor app_control * Fix reply bug * Check empty strings * Inline Create and Dispose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppControlResultaggressively.appId,operation,uri,mime,category, andcallerAppIdwhen receiving messages.AppControlManager.Insert()is called beforeAppControl.on_reply_is called to avoid subtle timing issues.AppControlChannel.GetAppControl()andAppControlChannel.SendAlreadyQueuedEvents().requestIdand usereplyIdinstead if available.Contributes to flutter-tizen/flutter-tizen#210.
I'll implement
GetMatchedAppIdsand some lifecycle events (especiallyin the next PR.onTerminate)