Add get native window interface #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-kim
reviewed
Nov 19, 2021
swift-kim
reviewed
Nov 19, 2021
1.Change interface name, make it more clearly. 2.Move HandleForRender and RendererFromHandle to unnamed namspace.
swift-kim
approved these changes
Nov 23, 2021
bwikbs
approved these changes
Nov 23, 2021
Member
bwikbs
left a comment
bwikbs
left a comment
There was a problem hiding this comment.
I guess platform view should also use this!
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Add get ecore window interface. * Change get window method name * Fix build error * Fix build error * Add comment for getting window interface * Remove not used code * Change interface name 1.Change interface name, make it more clearly. 2.Move HandleForRender and RendererFromHandle to unnamed namspace. * Get window from FlutterDesktopPluginRegistrarRef * Merge GetWindow and GetWindowHandle
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Add get ecore window interface. * Change get window method name * Fix build error * Add comment for getting window interface * Remove not used code * Change interface name 1.Change interface name, make it more clearly. 2.Move HandleForRender and RendererFromHandle to unnamed namspace. * Get window from FlutterDesktopPluginRegistrarRef * Merge GetWindow and GetWindowHandle
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Add get ecore window interface. * Change get window method name * Fix build error * Add comment for getting window interface * Remove not used code * Change interface name 1.Change interface name, make it more clearly. 2.Move HandleForRender and RendererFromHandle to unnamed namspace. * Get window from FlutterDesktopPluginRegistrarRef * Merge GetWindow and GetWindowHandle
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Add get ecore window interface. * Change get window method name * Fix build error * Add comment for getting window interface * Remove not used code * Change interface name 1.Change interface name, make it more clearly. 2.Move HandleForRender and RendererFromHandle to unnamed namspace. * Get window from FlutterDesktopPluginRegistrarRef * Merge GetWindow and GetWindowHandle
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Add get ecore window interface. * Change get window method name * Fix build error * Add comment for getting window interface * Remove not used code * Change interface name 1.Change interface name, make it more clearly. 2.Move HandleForRender and RendererFromHandle to unnamed namspace. * Get window from FlutterDesktopPluginRegistrarRef * Merge GetWindow and GetWindowHandle
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Add get ecore window interface. * Change get window method name * Fix build error * Add comment for getting window interface * Remove not used code * Change interface name 1.Change interface name, make it more clearly. 2.Move HandleForRender and RendererFromHandle to unnamed namspace. * Get window from FlutterDesktopPluginRegistrarRef * Merge GetWindow and GetWindowHandle
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Add get ecore window interface. * Change get window method name * Fix build error * Add comment for getting window interface * Remove not used code * Change interface name 1.Change interface name, make it more clearly. 2.Move HandleForRender and RendererFromHandle to unnamed namspace. * Get window from FlutterDesktopPluginRegistrarRef * Merge GetWindow and GetWindowHandle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement video player plugin with hole solution, it need engine provides get native window interface. we have to return to two types of windows(Elm window, Ecore_Wl2_window) for current status.
I think a good soluton would be to return only one type of window(Elm window), and I am trying to create elm window as root window and get ecore_wl2_window from elm window(#167)