Remove platform window handle at flutter_platform_view.h #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It will be replaced by ``FlutterDesktopGetWindow`` Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Member
|
Please also consider deprecating |
Member
Author
Of course. In this case, I guess it seems enough to change its name. BTW, This must have been pretty annoying you until now. Am I right? 😄 |
…Factory`` Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
approved these changes
Nov 24, 2021
HakkyuKim
reviewed
Nov 24, 2021
| public: | ||
| PlatformView(flutter::PluginRegistrar* registrar, | ||
| int view_id, | ||
| void* platform_window) |
There was a problem hiding this comment.
platform_window can be removed from constructor.
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Remove platform window handle at flutter_platform_view.h * It will be replaced by ``FlutterDesktopGetWindow`` Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Rename ``FlutterRegisterViewFactory`` to ``FlutterDesktopRegisterViewFactory`` Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be replaced by
FlutterDesktopGetWindowRelated #209