Skip to content

Remove stale test code #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2022
Merged

Remove stale test code #252

merged 4 commits into from
Mar 3, 2022

Conversation

@swift-kim
Copy link
Member

@swift-kim swift-kim commented Mar 2, 2022

The current test code for FlutterTizenEngine is confusing because two different test patterns (mock_engine.cc-based and MOCK_ENGINE_PROC-based) are being used simultaneously. We should only use a single consistent pattern.

bbrto21
bbrto21 reviewed Mar 3, 2022
View reviewed changes
Copy link

@bbrto21 bbrto21 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed tests are unit tests written to test each API of the engine.
Are you sure you want to remove them?(including headed version)

@swift-kim
Copy link
Member Author

swift-kim commented Mar 3, 2022

@bbrto21

  • Run, Stop, GetPluginRegistrar, and GetTextureRegistrar are tested by RunDoesExpectedInitialization so we don't have to test them again.
  • Invoking RunEngine or StopEngine twice is an undefined behavior and I don't think we need to test them.
  • The headed version of GetTextureRegistrar is already disabled and we don't have plan to support headed testing in the near future.

@swift-kim swift-kim merged commit eeee17d into flutter-tizen:flutter-2.10.1-tizen Mar 3, 2022
swift-kim added a commit that referenced this pull request May 12, 2022
@swift-kim
Remove stale test code (#252)
2670a0c 
* Remove mock_engine-based tests

* Use absolute paths

* Install libflutter_engine.so

* Let RunsAOTCompiledDartCode return false
swift-kim added a commit that referenced this pull request Aug 5, 2022
@swift-kim
Remove stale test code (#252)
37f91a0 
* Remove mock_engine-based tests

* Use absolute paths

* Install libflutter_engine.so

* Let RunsAOTCompiledDartCode return false
swift-kim added a commit that referenced this pull request Sep 1, 2022
@swift-kim
Remove stale test code (#252)
1f1ec57 
* Remove mock_engine-based tests

* Use absolute paths

* Install libflutter_engine.so

* Let RunsAOTCompiledDartCode return false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbrto21 bbrto21 bbrto21 approved these changes

@wanchao-xu wanchao-xu wanchao-xu approved these changes

@bwikbs bwikbs Awaiting requested review from bwikbs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swift-kim @bbrto21 @wanchao-xu