Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,10 @@ jobs:
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/download-artifact@v2
with:
name: tizen-arm-release

- uses: actions/download-artifact@v2
with:
name: tizen-arm-unittests
Expand Down
1 change: 0 additions & 1 deletion shell/platform/tizen/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ executable("flutter_tizen_unittests") {
"flutter_project_bundle_unittests.cc",
"flutter_tizen_engine_unittest.cc",
"flutter_tizen_texture_registrar_unittests.cc",
"testing/mock_engine.cc",
]

ldflags = [ "-Wl,--unresolved-symbols=ignore-in-shared-libs" ]
Expand Down
52 changes: 7 additions & 45 deletions shell/platform/tizen/flutter_tizen_engine_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ class FlutterTizenEngineTest : public ::testing::Test {

FlutterProjectBundle project(engine_prop);
auto engine = std::make_unique<FlutterTizenEngine>(project);

EngineModifier modifier(engine.get());
// Force the non-AOT path unless overridden by the test.
modifier.embedder_api().RunsAOTCompiledDartCode = []() { return false; };

engine_ = engine.release();
}

Expand All @@ -39,51 +44,6 @@ class FlutterTizenEngineTest : public ::testing::Test {
FlutterTizenEngine* engine_ = nullptr;
};

class FlutterTizenEngineTestHeaded : public FlutterTizenEngineTest {
protected:
void SetUp() {
FlutterTizenEngineTest::SetUp();
engine_->InitializeRenderer(0, 0, 800, 600, false, true, false);
}
};

TEST_F(FlutterTizenEngineTest, Run) {
EXPECT_TRUE(engine_ != nullptr);
EXPECT_TRUE(engine_->RunEngine(nullptr));
}

TEST_F(FlutterTizenEngineTest, Run_Twice) {
EXPECT_TRUE(engine_->RunEngine(nullptr));
EXPECT_FALSE(engine_->RunEngine(nullptr));
}

TEST_F(FlutterTizenEngineTest, Stop) {
EXPECT_TRUE(engine_->RunEngine(nullptr));
EXPECT_TRUE(engine_->StopEngine());
}

TEST_F(FlutterTizenEngineTest, Stop_Twice) {
EXPECT_TRUE(engine_->RunEngine(nullptr));
EXPECT_TRUE(engine_->StopEngine());
EXPECT_FALSE(engine_->StopEngine());
}

TEST_F(FlutterTizenEngineTest, GetPluginRegistrar) {
EXPECT_TRUE(engine_->RunEngine(nullptr));
EXPECT_TRUE(engine_->plugin_registrar() != nullptr);
}

TEST_F(FlutterTizenEngineTest, GetTextureRegistrar) {
EXPECT_TRUE(engine_->RunEngine(nullptr));
EXPECT_TRUE(engine_->texture_registrar() == nullptr);
}

// Disabled for headless testing.
TEST_F(FlutterTizenEngineTestHeaded, DISABLED_GetTextureRegistrar) {
EXPECT_TRUE(engine_->RunEngine(nullptr));
EXPECT_TRUE(engine_->texture_registrar() != nullptr);
}

TEST_F(FlutterTizenEngineTest, RunDoesExpectedInitialization) {
EngineModifier modifier(engine_);
bool run_called = false;
Expand Down Expand Up @@ -139,6 +99,8 @@ TEST_F(FlutterTizenEngineTest, RunDoesExpectedInitialization) {
EXPECT_TRUE(run_called);
EXPECT_TRUE(update_locales_called);
EXPECT_TRUE(settings_message_sent);
EXPECT_NE(engine_->plugin_registrar(), nullptr);
EXPECT_EQ(engine_->texture_registrar(), nullptr);

modifier.embedder_api().Shutdown = [](auto engine) { return kSuccess; };
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ class FlutterTizenTextureRegistrarTest : public ::testing::Test {
protected:
void SetUp() {
FlutterDesktopEngineProperties engine_prop = {};
engine_prop.assets_path = "foo/flutter_assets";
engine_prop.icu_data_path = "foo/icudtl.dat";
engine_prop.aot_library_path = "foo/libapp.so";
engine_prop.assets_path = "/foo/flutter_assets";
engine_prop.icu_data_path = "/foo/icudtl.dat";
engine_prop.aot_library_path = "/foo/libapp.so";

FlutterProjectBundle project(engine_prop);
auto engine = std::make_unique<FlutterTizenEngine>(project);
Expand Down
Loading