Skip to content

Make use of maybe_unused in WindowChannel #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2022
Merged

Make use of maybe_unused in WindowChannel #258

merged 1 commit into from
Mar 14, 2022

Conversation

@swift-kim
Copy link
Member

@swift-kim swift-kim commented Mar 10, 2022

  • Remove the pragma clang diagnostic ignored and replace with [[maybe_unused]].
  • Use explicit types (avoid auto).

@swift-kim swift-kim requested a review from HakkyuKim March 10, 2022 03:35
WonyoungChoi
WonyoungChoi approved these changes Mar 10, 2022
View reviewed changes
Copy link

@WonyoungChoi WonyoungChoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swift-kim swift-kim merged commit c16ea61 into flutter-tizen:flutter-2.10.1-tizen Mar 14, 2022
swift-kim added a commit that referenced this pull request May 12, 2022
@swift-kim
Make use of maybe_unused in WindowChannel (#258)
98486ba
swift-kim added a commit that referenced this pull request Aug 5, 2022
@swift-kim
Make use of maybe_unused in WindowChannel (#258)
4a54b43
swift-kim added a commit that referenced this pull request Sep 1, 2022
@swift-kim
Make use of maybe_unused in WindowChannel (#258)
e176d68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WonyoungChoi WonyoungChoi WonyoungChoi approved these changes

@HakkyuKim HakkyuKim Awaiting requested review from HakkyuKim

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swift-kim @WonyoungChoi