Skip to content

Make use of maybe_unused in WindowChannel #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Make use of maybe_unused in WindowChannel #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions shell/platform/tizen/channels/window_channel.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-private-field"
#include "window_channel.h"
#pragma clang diagnostic pop

#include "flutter/shell/platform/common/client_wrapper/include/flutter/standard_method_codec.h"
#include "flutter/shell/platform/tizen/channels/encodable_value_holder.h"
Expand All @@ -25,9 +22,11 @@ WindowChannel::WindowChannel(BinaryMessenger* messenger,
: renderer_(renderer), delegate_(delegate) {
channel_ = std::make_unique<MethodChannel<EncodableValue>>(
messenger, kChannelName, &StandardMethodCodec::GetInstance());
channel_->SetMethodCallHandler([this](const auto& call, auto result) {
this->HandleMethodCall(call, std::move(result));
});
channel_->SetMethodCallHandler(
[this](const MethodCall<EncodableValue>& call,
std::unique_ptr<MethodResult<EncodableValue>> result) {
this->HandleMethodCall(call, std::move(result));
});
}

WindowChannel::~WindowChannel() {}
Expand All @@ -47,10 +46,10 @@ void WindowChannel::HandleMethodCall(
result->Success(EncodableValue(map));
} else if (method_name == "setWindowGeometry") {
#ifdef TIZEN_RENDERER_EVAS_GL
FT_LOG(Error) << "setWindowGeometry is not supported on evas_gl.";
FT_LOG(Error) << "setWindowGeometry is not supported on Evas GL.";
result->NotImplemented();
#else
auto arguments = std::get_if<EncodableMap>(method_call.arguments());
const auto* arguments = std::get_if<EncodableMap>(method_call.arguments());
if (!arguments) {
result->Error("Invalid arguments");
return;
Expand Down
3 changes: 2 additions & 1 deletion shell/platform/tizen/channels/window_channel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ class WindowChannel {
// A reference to the renderer object managed by FlutterTizenEngine.
// This can be nullptr if the engine is running in headless mode.
TizenRenderer* renderer_;
TizenRenderer::Delegate* delegate_;

[[maybe_unused]] TizenRenderer::Delegate* delegate_;
};

} // namespace flutter
Expand Down