forked from flutter/engine
-
Notifications
You must be signed in to change notification settings - Fork 17
Fix an invalid engine handle error #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* To send something to the engine, the engine must be running. * FlutterTizenView::SendInitialGeometry is used to send the geometry after running the engine Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
reviewed
May 9, 2022
swift-kim
approved these changes
May 9, 2022
Member
Not directly related to this patch, but... if (!view->engine()->IsRunning()) {
view->engine()->RunEngine();
}
view->SendInitialGeometry();How about adding an if condition? |
Author
|
@JSUYA As you already mentioned, I also don't think that's the scope of this PR. So if you really think it's necessary, you can open the PR yourself. |
Member
Author
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* To send something to the engine, the engine must be running. * FlutterTizenView::SendInitialGeometry is used to send the geometry after running the engine Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* To send something to the engine, the engine must be running. * FlutterTizenView::SendInitialGeometry is used to send the geometry after running the engine Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* To send something to the engine, the engine must be running. * FlutterTizenView::SendInitialGeometry is used to send the geometry after running the engine Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after running the engine
Signed-off-by: Boram Bae boram21.bae@samsung.com
Fixes flutter-tizen/flutter-tizen#361.