Skip to content

Conversation

@bbrto21
Copy link

@bbrto21 bbrto21 commented May 9, 2022

  • To send something to the engine, the engine must be running.
  • FlutterTizenView::SendInitialGeometry is used to send the geometry
    after running the engine

Signed-off-by: Boram Bae boram21.bae@samsung.com

Fixes flutter-tizen/flutter-tizen#361.

* To send something to the engine, the engine must be running.
* FlutterTizenView::SendInitialGeometry is used to send the geometry
  after running the engine

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
@bbrto21 bbrto21 requested review from JSUYA and swift-kim May 9, 2022 05:40
@flutter-tizen flutter-tizen deleted a comment from bbrto21 May 9, 2022
@JSUYA
Copy link
Member

JSUYA commented May 9, 2022

  • FlutterTizenView::SendInitialGeometry is used to send the geometry
    after running the engine

Not directly related to this patch, but...
SendInitialGeometry() is called regardless of engine run fail.

  if (!view->engine()->IsRunning()) {
    view->engine()->RunEngine();
  }

  view->SendInitialGeometry();

How about adding an if condition?

@bbrto21
Copy link
Author

bbrto21 commented May 10, 2022

@JSUYA As you already mentioned, I also don't think that's the scope of this PR. So if you really think it's necessary, you can open the PR yourself.

@swift-kim
Copy link
Member

@bbrto21 @JSUYA That looks like a bug we currently have. FlutterDesktopViewCreateFromNewWindow should return nullptr if RunEngine fails. That is,

if (!view->engine()->IsRunning()) {
  if (!view->engine()->RunEngine()) {
    return nullptr;
  }
}

@bbrto21 bbrto21 merged commit ea9c232 into flutter-tizen:flutter-2.10.1-tizen May 10, 2022
@bbrto21
Copy link
Author

bbrto21 commented May 10, 2022

@bbrto21 @JSUYA That looks like a bug we currently have. FlutterDesktopViewCreateFromNewWindow should return nullptr if RunEngine fails. That is,

@JSUYA Would you please fix this bug?

swift-kim pushed a commit that referenced this pull request May 12, 2022
* To send something to the engine, the engine must be running.
* FlutterTizenView::SendInitialGeometry is used to send the geometry
  after running the engine

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim pushed a commit that referenced this pull request Aug 5, 2022
* To send something to the engine, the engine must be running.
* FlutterTizenView::SendInitialGeometry is used to send the geometry
  after running the engine

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
* To send something to the engine, the engine must be running.
* FlutterTizenView::SendInitialGeometry is used to send the geometry
  after running the engine

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: 'FlutterEngineSendWindowMetricsEvent' returned 'kInvalidArguments'

3 participants