Return nullptr if RunEngine fails #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This topic was mentioned in #282. |
If RunEngine() fails, it should immediately return.
JSUYA
force-pushed
the
devs/fix_runengine_fail
branch
from
8102687 to
755e098
Compare
swift-kim
approved these changes
May 10, 2022
bbrto21
approved these changes
May 10, 2022
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
If RunEngine() fails, it should immediately return.
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
If RunEngine() fails, it should immediately return.
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
If RunEngine() fails, it should immediately return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If RunEngine() fails, it should immediately return.