Cleanup when destroying view and engine #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The view should be responsible for the life cycle of the engine, and the engine should stop naturally when the view is destroyed. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
approved these changes
Jun 28, 2022
* There is no need to explicitly assign null to a unique pointer in the destructor of engine. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* The view should be responsible for the life cycle of the engine, and the engine should stop naturally when the view is destroyed. * There is no need to explicitly assign null to a unique pointer in the destructor of engine. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* The view should be responsible for the life cycle of the engine, and the engine should stop naturally when the view is destroyed. * There is no need to explicitly assign null to a unique pointer in the destructor of engine. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the engine should stop naturally when the view is destroyed.
Signed-off-by: Boram Bae boram21.bae@samsung.com