Skip to content

Re-enable analyzer rules temporarily disabled for Flutter 3.47.0 #1089

Description

@JSUYA

To unblock the analyze CI after the stable Flutter 3.47.0 upgrade (#1088), five diagnostics newly reported by the Dart 3.13.0 analyzer were temporarily suppressed in the root analysis_options.yaml instead of modifying code. Each suppression is marked with a TODO(jsuya): Different from flutter/packages comment referencing this issue.

This issue tracks re-enabling them. Each task below removes one suppression after fixing the affected package(s) in a follow-up PR.

Tasks

1. use_super_parameters — google_maps_flutter

  • Sync the example app with the upstream flutter/packages example, which already uses super.key (19 files under example/lib/), then re-enable the rule.

2. collection_methods_unrelated_type — tizen_bundle

  • The two reports in example/integration_test/tizen_bundle_test.dart are false positives from intentional null-handling tests (bundle[null], bundle.remove(null)). Add // ignore: collection_methods_unrelated_type to those lines (first-party code), then re-enable the rule.

3. strict_top_level_inference — video_player_avplay, video_player_videohole

  • Add the missing parameter type in both packages (void _afterFrameLayout(Duration _) in lib/video_player.dart), then re-enable the rule.

4. unintended_html_in_doc_comment — in_app_purchase

  • Wrap the angle-bracketed types in backticks in two doc comments of lib/src/in_app_purchase_tizen_platform.dart (Map<Object?, Object?>?`Map<Object?, Object?>?`), then re-enable the rule.

Deferred upstream settings (repo-wide migrations)

The following settings from the upstream flutter/packages analysis_options.yaml are also disabled with the same TODO markers. They require repo-wide migration rather than per-package fixes.

5. omit_obvious_local_variable_types — repo-wide

  • Migrate the existing code, which still follows the old always_specify_types style (hundreds of violations), then enable the rule.

6. formatter: page_width: 100 — repo-wide

  • Reformat the repository with a line length of 100, then enable the setting.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions