Apply new texture APIs #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Contributes to flutter-tizen/engine/issues/285. * This change depends on flutter-tizen/engine/pull/338. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
bbrto21
added
no merge
swift-kim
reviewed
Sep 6, 2022
Comment on lines
350
to
353
| flutter_desktop_gpu_buffer_->width = width; | ||
| flutter_desktop_gpu_buffer_->visible_width = width; | ||
| flutter_desktop_gpu_buffer_->height = height; | ||
| flutter_desktop_gpu_buffer_->visible_height = height; |
Member
There was a problem hiding this comment.
These four values are unused by the embedder so I think you can remove the lines (or at least visible_*).
Contributor
Author
There was a problem hiding this comment.
I removed them from all over this PR.
Member
There was a problem hiding this comment.
Okay, we still keep width and height although they are unused.
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
reviewed
Sep 6, 2022
| gpu_surface_->width = width; | ||
| gpu_surface_->height = height; | ||
| gpu_surface_->release_callback = [](void *release_context) { | ||
| CameraDevice *cd = (CameraDevice *)release_context; |
Member
There was a problem hiding this comment.
We may need another PR to do some refactoring (to fix the C type cast).
Contributor
Author
There was a problem hiding this comment.
I also think another PR is better.
swift-kim
approved these changes
Sep 6, 2022
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boram Bae boram21.bae@samsung.com