Skip to content

Migrate to the new GpuSurfaceTexture API #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2022
Merged

Migrate to the new GpuSurfaceTexture API #338

merged 1 commit into from
Sep 5, 2022

Conversation

@swift-kim
Copy link
Member

@swift-kim swift-kim commented Sep 2, 2022

Migrate from the outdated FlutterDesktopGpuBuffer-based APIs to the official FlutterDesktopGpuSurfaceDescriptor-based APIs.

Contributes to #285.

Plugins that use the relevant texture API must be updated as well.

@bwikbs
Copy link
Member

bwikbs commented Sep 2, 2022

Now I can build this branch! 😄

@JSUYA
Copy link
Member

JSUYA commented Sep 2, 2022

https://github.com/flutter-tizen/engine/runs/8150324971?check_suite_focus=true#step:6:290
It's probably clang-format version 15.
How about changing clang_format_path of visual code tool to clang-format of llvm-project?

@swift-kim swift-kim force-pushed the new-gpu-buffer-texture branch from 1f64f86 to d624f02 Compare September 3, 2022 14:55
bwikbs
bwikbs approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swift-kim
Copy link
Member Author

swift-kim commented Sep 5, 2022

@JSUYA Hmm. Developers do not use their IDE for engine development only so setting clang_format_path to the engine toolchain's clang-format path doesn't seem a very good solution. Most developers should not have any problem if they don't specify clang_format_path and just use clang-format bundled with the latest C/C++ extension. For CLI users, I'd recommend to download and install clang-format-15 directly from https://apt.llvm.org/. I'll update https://github.com/flutter-tizen/flutter-tizen/wiki/Style-guide soon.

bbrto21 added a commit to bbrto21/plugins that referenced this pull request Sep 5, 2022
@bbrto21
Apply new texture APIs
ed19d36 
* Contributes to flutter-tizen/engine/issues/285.
* This change depends on flutter-tizen/engine/pull/338.

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
@bbrto21 bbrto21 mentioned this pull request Sep 5, 2022
Merged
@swift-kim swift-kim merged commit aa0b834 into flutter-tizen:flutter-3.3.0-tizen Sep 5, 2022
swift-kim pushed a commit to flutter-tizen/plugins that referenced this pull request Sep 8, 2022
@bbrto21
Apply new texture APIs (#434)
87d03be 
* Contributes to flutter-tizen/engine/issues/285.
* This change depends on flutter-tizen/engine/pull/338.

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwikbs bwikbs bwikbs approved these changes

@bbrto21 bbrto21 Awaiting requested review from bbrto21

@JSUYA JSUYA Awaiting requested review from JSUYA

@xiaowei-guan xiaowei-guan Awaiting requested review from xiaowei-guan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swift-kim @bwikbs @JSUYA